-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Fixed FieldTest, RestContentTest, and RestUser(Group)Test #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
fix-incorrect-section-id
branch
from
March 28, 2024 09:55
8b82650
to
f317269
Compare
alongosz
changed the title
[Tests] Fixed incorrect section ID data type
[Tests] Fixed FieldTest, RestContentTest, and RestUser(Group)Test
Mar 28, 2024
alongosz
force-pushed
the
fix-incorrect-section-id
branch
from
March 28, 2024 14:02
b67f37c
to
953eb28
Compare
alongosz
force-pushed
the
fix-incorrect-section-id
branch
from
March 28, 2024 15:06
953eb28
to
b69f6a9
Compare
Quality Gate passedIssues Measures |
ciastektk
approved these changes
Mar 29, 2024
konradoboza
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed https://github.com/ibexa/rest/actions/runs/8439148113/job/23113060154.
1. Fixed incorrect section ID data type.
We've recently enforced strict type on
sectionId
to catch some bugs and here we've caught one.2. Fixed failing Field Value Object Visitor test
Ibexa\Tests\Rest\Server\Output\ValueObjectVisitor\FieldTest
test was actually silently failing with a warning due to incorrect mocking ofserializeContentFieldValue
. It performs operations internally and applies results to an instance of REST XMLGenerator
instead of returning a value. It wasn't visible becausefailOnWarning
was not configured (fixed as well).Instead we need to mock a bit behavior of field type services to properly mock hash that the generator will use.
int ID
data types (the same way as the section ID): owner, content, main location, content type