Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7911: Replaced usage of magic getters for load subtree code paths #76

Merged
merged 3 commits into from
Jun 5, 2024
Merged

IBX-7911: Replaced usage of magic getters for load subtree code paths #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f536693
Introduced Value Object strict getters and deprecated magic ones
alongosz Mar 8, 2024
8e68224
[CS] Fixed outstanding CS issue in UserSetting class
alongosz May 23, 2024
4e13ab5
Fixed @property-read deprecation message to follow the convention
alongosz May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/Strategy/DefaultThumbnailStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ private function getInitials(array $fields): string
foreach ($this->initialsFieldDefIdentifiers as $identifier) {
/** @var \Ibexa\Contracts\Core\Repository\Values\Content\Field $field */
foreach ($fields as $field) {
if ($field->fieldDefIdentifier === $identifier) {
$initials .= substr((string)$field->value, 0, 1);
if ($field->getFieldDefinitionIdentifier() === $identifier) {
$initials .= substr((string)$field->getValue(), 0, 1);
}
}
}
Expand Down
29 changes: 24 additions & 5 deletions src/lib/UserSetting/UserSetting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?php

Check warning on line 1 in src/lib/UserSetting/UserSetting.php

View workflow job for this annotation

GitHub Actions / Run code style check (8.1) 

Found violation(s) of type: class_attributes_separation

/**
* @copyright Copyright (C) Ibexa AS. All rights reserved.
Expand All @@ -11,16 +11,15 @@
use Ibexa\Contracts\Core\Repository\Values\ValueObject;

/**
* @property string $identifier
* @property string $name
* @property string $description
* @property string $value
* @property string $identifier @deprecated use {@see UserSetting::getIdentifier()} instead.
* @property string $name @deprecated use {@see UserSetting::getName()} instead.
* @property string $description @deprecated use {@see UserSetting::getDescription()} instead.
* @property string $value @deprecated use {@see UserSetting::getValue()} instead.
alongosz marked this conversation as resolved.
Show resolved Hide resolved
*/
class UserSetting extends ValueObject
{
/** @var string */
protected $identifier;

/** @var string */
protected $name;

Expand All @@ -29,6 +28,26 @@

/** @var string */
protected $value;

public function getIdentifier(): string
{
return $this->identifier;
}

public function getName(): string
{
return $this->name;
}

public function getDescription(): string
{
return $this->description;
}

public function getValue(): string
{
return $this->value;
}
}

class_alias(UserSetting::class, 'EzSystems\EzPlatformUser\UserSetting\UserSetting');
Loading