Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7862: Fixed user setting value #77

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Apr 8, 2024

🎫 Issue IBX-7862

Description:

When a user has set preferred languages in his browser the first of them is taken into account. The current solution tries to find an intersection between preferred and available languages.

For QA:

Documentation:

@mikadamczyk mikadamczyk self-assigned this Apr 8, 2024
@mikadamczyk mikadamczyk changed the base branch from main to 4.6 April 8, 2024 12:54
@mikadamczyk mikadamczyk marked this pull request as ready for review April 8, 2024 12:57
@mikadamczyk mikadamczyk requested a review from a team April 8, 2024 12:57
tests/lib/UserSetting/Setting/LanguageTest.php Outdated Show resolved Hide resolved
tests/lib/UserSetting/Setting/LanguageTest.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team April 17, 2024 10:03
@mikadamczyk mikadamczyk force-pushed the IBX-7862-language-setting branch 2 times, most recently from d0b7503 to 27dbb82 Compare April 17, 2024 13:03
tests/lib/UserSetting/Setting/LanguageTest.php Outdated Show resolved Hide resolved
tests/lib/UserSetting/Setting/LanguageTest.php Outdated Show resolved Hide resolved
tests/lib/UserSetting/Setting/LanguageTest.php Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk requested a review from a team May 10, 2024 07:26
Copy link

sonarcloud bot commented Jul 17, 2024

@juskora
Copy link

juskora commented Jul 18, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@mikadamczyk mikadamczyk merged commit f4f48cf into 4.6 Jul 18, 2024
14 checks passed
@mikadamczyk mikadamczyk deleted the IBX-7862-language-setting branch July 18, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants