Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHPStan #78

Merged
merged 5 commits into from
Apr 13, 2024
Merged

Added PHPStan #78

merged 5 commits into from
Apr 13, 2024

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Apr 9, 2024

Question Answer
Tickets N/A
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@Steveb-p Steveb-p requested a review from a team April 9, 2024 10:28
konradoboza
konradoboza reviewed Apr 9, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
src/lib/UserSetting/ValueDefinitionGroupRegistryEntry.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team April 9, 2024 10:30
@Steveb-p Steveb-p changed the base branch from main to 4.5 April 9, 2024 10:44
@konradoboza konradoboza requested a review from a team April 9, 2024 10:45
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs merged commit acf322d into 4.5 Apr 13, 2024
14 checks passed
@adamwojs adamwojs deleted the phpstan branch April 13, 2024 18:43
@adamwojs
Copy link
Member

@Steveb-p Could you please merge up changed?

@Steveb-p
Copy link
Contributor Author

@Steveb-p Could you please merge up changed?

@adamwojs merged up in ca8da09 (4.5) & 0b82ed3 (main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@ciastektk ciastektk ciastektk approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@ViniTou ViniTou

Labels
Improvement Ready for MERGE Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @adamwojs @ciastektk @konradoboza @mikadamczyk @ViniTou