docs: correct link generated in operations matrix #10345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibis-docs-bot
bot
removed
the
docs-preview
|
@Jlobblet Thanks! I've kicked off a docs-preview job for this PR, so in about 10-15 minutes we can check that your fix works! |
|
Looks like there are still some oddities around things present in the matrix but not the reference (e.g., DenseRank) but that is beyond the scope of this PR |
|
Other things I have spotted so far that don't match up:
|
|
Yep, I think we are simply missing all those in the API docs. I'm not sure if we can generate them automatically and keep the same layout. At the moment we're simply listing all the operations we want to show up in the docs in |
|
In any event, I'm going to merge this PR. Thanks again! |
cpcloud
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The operation support matrix has links to each operation, but they don’t work. This fixes that by updating the link to the current address of those operations.
Issues closed