fix: fix order of limit and offset param in Clickhouse. #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 19 files 19 suites 1h 34m 55s ⏱️ Results for commit cb7911c. ♻️ This comment has been updated with latest results. |
|
I've submitted a PR to try to workaround the impyla dependency bugs you uncovered (#2987) to unblock your PRs. |
|
@Lunaticus7 Can you rebase this to pick up the fixes to CI? |
cpcloud
added
clickhouse
|
Merging on green. |
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Sep 20, 2021
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Sep 20, 2021
cpcloud
added a commit
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #2983
The order of limit and offset in compiled SQL is reversed 🤣.
https://clickhouse.tech/docs/en/sql-reference/statements/select/limit/#limit-clause