Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add length parameter to the String datatype #9701

Closed
wants to merge 1 commit into from
Closed

feat(api): add length parameter to the String datatype #9701

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 26, 2024 •
edited
Loading

Adds an optional length parameter to the String datatype.

Closes #9382.

@cpcloud cpcloud added feature Features or general enhancements refactor Issues or PRs related to refactoring the codebase datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Jul 26, 2024
@cpcloud cpcloud added this to the 10.0 milestone Oct 20, 2024
@cpcloud cpcloud force-pushed the string-length branch 2 times, most recently from 759cf83 to ec62bf3 Compare October 20, 2024 14:25
@github-actions github-actions bot added tests Issues or PRs related to tests postgres The PostgreSQL backend clickhouse The ClickHouse backend sql Backends that generate SQL mssql The Microsoft SQL Server backend trino The Trino backend labels Oct 20, 2024
@github-actions github-actions bot added the mysql The MySQL backend label Oct 21, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Oct 21, 2024

I am unlikely to have time to wrap this up, as implementing this well requires handling cases like union of string columns with string(N) columns which would require deeper changes to the type system.

@cpcloud cpcloud closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clickhouse The ClickHouse backend datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) feature Features or general enhancements mssql The Microsoft SQL Server backend mysql The MySQL backend postgres The PostgreSQL backend refactor Issues or PRs related to refactoring the codebase sql Backends that generate SQL tests Issues or PRs related to tests trino The Trino backend
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

feat: allow specify the length of string column
1 participant
@cpcloud