Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated istio doc to reflect changes #214

Open
wants to merge 2 commits into
base: microprofile
Choose a base branch
from

Conversation

jjvilleg
Copy link

@jjvilleg jjvilleg commented Dec 6, 2019

No description provided.

@jjvilleg jjvilleg requested a review from evie-lau December 6, 2019 14:46
Copy link

@evie-lau evie-lau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does istio need to be capitalized everywhere?


### Telemetry

The running application has the default distributed tracing implementation that istio provides. These metrics are provided by default when running on an istio enavbled environment. No extra configuration is needed. Microprofile supplements istio's [metrics](https://istio.io/docs/reference/config/policy-and-telemetry/metrics/) with it's own [metrics](https://github.com/eclipse/microprofile-metrics) data.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on enabled


The Microprofile Spec provides fault tolerance policies that allow for timeout, retry, bulkhead, circuit breaker, and fallback properties to be configured. With the exception of fallback, istio also provides these policies. The BlueCompute application makes use of the microprofile timeout, retry, and fallback policies.

Even though the MP fault tolerant policies are configured at the application level, it is fairly easy to disable and replace them with the istio implementation. The Blue Compute application demonstrates this with the timeout policy. When istio is enabled for the application, a config map property is passed to the application that disables the MP timeout policy, and instead enables a timeout policy that is configured at the istio level, avoiding a conflict that multiplies the configured time out level when both the MP and Istio policies are enabled.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlueCompute as one word

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants