P11 JSON:Refactored rainier 4U system JSON. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PriyangaRamasamy
requested review from
jinuthomas,
souvik1914581,
SunnySrivastava1984,
RekhaAparna01 and
branupama
PriyangaRamasamy
force-pushed
the
P11-json-50001000
branch
from
1901c43
to
6b43590
Compare
SunnySrivastava1984
requested changes
Sep 12, 2024
configuration/ibm/50001000.json
Outdated
| } | ||
| }, | ||
| { | ||
| "inventoryPath": "/system", |
There was a problem hiding this comment.
We need full path under inventory path for FRUs.
| "serviceName": "xyz.openbmc_project.Inventory.Manager", | ||
| "pcaChipAddress": "5-0060", | ||
| "replaceableAtStandby": true, | ||
| "concurrentlyMaintainable": true, |
There was a problem hiding this comment.
We need to come up with a new name for this flag. I am assuming that will be taken care as a part of defect/issue?
There was a problem hiding this comment.
this will be taken care with this issue #349
This commit has rainier 4U system JSON refactored with the following modifications. 1. Added devTree tag. 2. Added backupRestoreConfigPath tag. 3. Added serviceName in every parent FRU and sub FRU section. 4. Modified pollingRequired section. 5. Modified preAction and PostFailAction sections. 6. Removed busType, driverType and devAddress as we have systemCmd tag which has command to bind. 7. Added postAction section 8. Modified inventoryPath value Signed-off-by: PriyangaRamasamy <[email protected]>
PriyangaRamasamy
force-pushed
the
P11-json-50001000
branch
from
6b43590
to
6c5f0b3
Compare
SunnySrivastava1984
requested changes
Oct 9, 2024
| } | ||
| } | ||
| }, | ||
| "postAction": { |
There was a problem hiding this comment.
Why post action has been defined for this card?
| } | ||
| } | ||
| }, | ||
| "postAction": { |
There was a problem hiding this comment.
Same here. Why post action needs to be defined for this card?
| } | ||
| } | ||
| }, | ||
| "postAction": { |
There was a problem hiding this comment.
Same here. Why post action has been defined for this card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has rainier 4U system JSON refactored with the following modifications.
which has command to bind.