-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18 & Patternfly 5 Upgrades #494
React 18 & Patternfly 5 Upgrades #494
Conversation
@LightOfHeaven1994 For some reason alerts doesn't go away when i import archive |
@LightOfHeaven1994 thanks for picking this up - Can you address @computercamplove concern above, and look at updating the frontend container to node:18 in this? I'm hitting some of this in this MR, where I included a change to node:18 for the Node 16 is past end of life and we need to update it - I don't want 498 to completely turn into this PR, I started addressing some of the deprecations and then saw you're doing that here. I'll keep node:16 in MR498's branch and then can rebase on top of this? |
I can reproduce it. Will take a look 👍 |
This happens because you probably used "Project 1" when you were uploading results, but then you switched to another project that has no these uploads (no data). This is not a bug but it's just how ibutsu RBAC works |
167fcda
to
0848b65
Compare
fixed :) |
b8e9a00
to
4e1b832
Compare
- Upgrade Patternfly from v4 to v5 - Upgrade React from 17 to 18 - Upgrade react router from v5 to v6 - Upgrade packages & replace some unrelevant - Fix stylings - Make linter happy - Make tests work - Format code for better visibility - Create elementWrapper helper component to make router v6 work - Fix some warnings - Some bugfixes to already existing issues - Minor backend issue fix - Make filtering work for ibutsu projects on backend side - Remove unused components
929e3c1
to
7572b89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is obviously a ton here, but deployed and running locally with some test results imported and a dashboard created with a few widgets, everything is looking great!
The header is behaving well, and the improved rendering on the test result json object is a nice treat.
Thanks for maintaining Ibutsu and managing this upgrade - and all of the dependency resolution headaches that came with it!
I'm going to immediately start to take advantage of both the react-router upgrade's navigation hooks, and some of the PF5 components changes for the portal dashboards.
This PR contains:
1. React router dom upgrade v5 -> v6
2. React upgrade 17 -> 18
3. Patternfly upgrade 4 -> 5
4. Other packages upgrade
5. Couple minor backend bugfixes (this was needed to test Frontend changes)
6. Small Frontend bugfixes/improvements
7. Test fixes