Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 & Patternfly 5 Upgrades #494

Merged

Conversation

LightOfHeaven1994
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 commented Apr 9, 2024

This PR contains:
1. React router dom upgrade v5 -> v6
2. React upgrade 17 -> 18
3. Patternfly upgrade 4 -> 5
4. Other packages upgrade
5. Couple minor backend bugfixes (this was needed to test Frontend changes)
6. Small Frontend bugfixes/improvements
7. Test fixes

@LightOfHeaven1994 LightOfHeaven1994 changed the title React 18 & Patternfly 5 Upgrades DO NOT MERGE: React 18 & Patternfly 5 Upgrades Apr 9, 2024
@LightOfHeaven1994 LightOfHeaven1994 changed the title DO NOT MERGE: React 18 & Patternfly 5 Upgrades UNDER REVIEW: React 18 & Patternfly 5 Upgrades May 7, 2024
@computercamplove
Copy link

@LightOfHeaven1994 For some reason alerts doesn't go away when i import archive
Screenshot from 2024-05-17 18-51-45, even if i navigate to different page, only when i reload page.
could you reproduce it?

@computercamplove
Copy link

computercamplove commented May 17, 2024

  1. Jenkins heatmap is not working for me, i copied same settings from production
    image

update: the issue is not in widget but in what metadata i use - it works for singe plugin, but not for common-pipelines/{prod-test-suite}

@mshriver
Copy link
Contributor

mshriver commented Jun 3, 2024

@LightOfHeaven1994 thanks for picking this up - Can you address @computercamplove concern above, and look at updating the frontend container to node:18 in this?

#498

I'm hitting some of this in this MR, where I included a change to node:18 for the ibutsu-pod.sh script for local dev envs.

Node 16 is past end of life and we need to update it - I don't want 498 to completely turn into this PR, I started addressing some of the deprecations and then saw you're doing that here.

I'll keep node:16 in MR498's branch and then can rebase on top of this?

@LightOfHeaven1994
Copy link
Collaborator Author

@LightOfHeaven1994 For some reason alerts doesn't go away when i import archive Screenshot from 2024-05-17 18-51-45, even if i navigate to different page, only when i reload page. could you reproduce it?

I can reproduce it. Will take a look 👍

@LightOfHeaven1994
Copy link
Collaborator Author

  1. Jenkins heatmap is not working for me, i copied same settings from production
    image

update: the issue is not in widget but in what metadata i use - it works for singe plugin, but not for common-pipelines/{prod-test-suite}

This happens because you probably used "Project 1" when you were uploading results, but then you switched to another project that has no these uploads (no data). This is not a bug but it's just how ibutsu RBAC works

@mshriver mshriver self-assigned this Jun 6, 2024
@mshriver mshriver added enhancement New feature or request frontend dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 6, 2024
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the react-18-pf-5-upgrades branch 2 times, most recently from 167fcda to 0848b65 Compare June 6, 2024 12:17
@LightOfHeaven1994
Copy link
Collaborator Author

@LightOfHeaven1994 For some reason alerts doesn't go away when i import archive Screenshot from 2024-05-17 18-51-45, even if i navigate to different page, only when i reload page. could you reproduce it?

fixed :)

@LightOfHeaven1994 LightOfHeaven1994 marked this pull request as ready for review June 6, 2024 12:19
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the react-18-pf-5-upgrades branch from b8e9a00 to 4e1b832 Compare June 6, 2024 18:48
@LightOfHeaven1994 LightOfHeaven1994 changed the title UNDER REVIEW: React 18 & Patternfly 5 Upgrades React 18 & Patternfly 5 Upgrades Jun 7, 2024
- Upgrade Patternfly from v4 to v5
- Upgrade React from 17 to 18
- Upgrade react router from v5 to v6
- Upgrade packages & replace some unrelevant
- Fix stylings
- Make linter happy
- Make tests work
- Format code for better visibility
- Create elementWrapper helper component to make router v6 work
- Fix some warnings
- Some bugfixes to already existing issues
- Minor backend issue fix
- Make filtering work for ibutsu projects on backend side
- Remove unused components
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the react-18-pf-5-upgrades branch from 929e3c1 to 7572b89 Compare June 7, 2024 11:29
@mshriver mshriver requested review from mshriver and jjaquish June 7, 2024 15:01
Copy link
Contributor

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is obviously a ton here, but deployed and running locally with some test results imported and a dashboard created with a few widgets, everything is looking great!

The header is behaving well, and the improved rendering on the test result json object is a nice treat.

Thanks for maintaining Ibutsu and managing this upgrade - and all of the dependency resolution headaches that came with it!

I'm going to immediately start to take advantage of both the react-router upgrade's navigation hooks, and some of the PF5 components changes for the portal dashboards.

@LightOfHeaven1994 LightOfHeaven1994 merged commit 367f293 into ibutsu:master Jun 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request frontend javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants