Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MySQL driver in setup.properties.example #15

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

RKrahl
Copy link
Member

@RKrahl RKrahl commented Aug 4, 2023

This is the same issue as icatproject/icat.server#311:

The MySQL section in the setup.properties.example file is outdated. The class com.mysql.jdbc.jdbc2.optional.MysqlDataSource does not exist any more in recent versions of mysql-connector-java. The driver needs to be updated to com.mysql.cj.jdbc.MysqlDataSource.

I don't know exactly at which version of mysql-connector-java this change has been made. But I believe, it's a while ago and at least any version that supports Java 11 requires the new class. So it should be safe to update that in the example file unconditionally.

@ajkyffin ajkyffin merged commit 10c72d1 into icatproject:master Sep 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants