-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18 search improvements #27
base: master
Are you sure you want to change the base?
Conversation
Bumps `luceneVersion` from 5.3.0 to 8.6.0. Updates `lucene-core` from 5.3.0 to 8.6.0 Updates `lucene-queryparser` from 5.3.0 to 8.6.0 Updates `lucene-analyzers-common` from 5.3.0 to 8.6.0 Updates `lucene-join` from 5.3.0 to 8.6.0 Signed-off-by: dependabot[bot] <[email protected]>
…n-8.6.0 Dependabot/maven/lucene version 8.6.0 into 18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is quite a lot going on here so I must admit that it's hard for me to understand everything but I tried my best.
I can see that you have refactored code into private methods to make some methods shorter but there are still a few methods (i.e. luceneFacetResult
, luceneSearchResult
etc in the Lucene
class) that are long so have a look to see if you can shorten them.
In addition to the smaller stuff (use of
|
Covers a variety of improvements to free text search functionality.
Closes #18 #19 #25 #26 #30
Functional changes
Added the ability to:
searchAfter
parametertext
field into more specific fields that reflect the ICAT schema to allow field targettingParameter
sArchitectural changes
In addition to changes to various functions on the main
Lucene
class:DocumentMapping
FacetedDimension
to store the results of a request to facet the documentsSearch
fromLucene
into its own dedicatedSearchBucket
class to handle building of complex queries and additional searching parameters (e.g. sorting)ShardBucket
added alongsideIndexBucket
inLucene
to reflect the distinction between a single directory of Lucene Documents (ShardBucket
) and a way to access all Documents of one entity type contained in one or more directories (IndexBucket
)Interdependencies on other components