Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed getLink() api call #149

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Removed getLink() api call #149

wants to merge 6 commits into from

Conversation

LewerenzM
Copy link
Contributor

@LewerenzM LewerenzM commented Dec 15, 2023 •
edited
Loading

The getLink(...) api call and its tests were removed.

Close #148

@RKrahl RKrahl added the remove feature Proposal to remove some feature label Dec 15, 2023
@RKrahl RKrahl added this to the 3.0.0 milestone Dec 15, 2023
RKrahl
RKrahl requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@RKrahl RKrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still found a few residues of this feature and related data structures in the code. Most prominently: you should also remove the deletion of old links in the Tidier.

src/main/java/org/icatproject/ids/PropertyHandler.java Outdated Show resolved Hide resolved
src/main/java/org/icatproject/ids/IdsBean.java Outdated Show resolved Hide resolved
src/main/java/org/icatproject/ids/IdsBean.java Outdated Show resolved Hide resolved
@RKrahl RKrahl self-requested a review December 18, 2023 14:19
RKrahl
RKrahl approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@RKrahl RKrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RKrahl RKrahl RKrahl approved these changes

Assignees
No one assigned
Labels
remove feature Proposal to remove some feature
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Drop getLink API call
2 participants
@LewerenzM @RKrahl