-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding linter #163
Draft
LewerenzM
wants to merge
20
commits into
v3_FileInfoImprovementAndRequestHandler
Choose a base branch
from
v3_linting
base: v3_FileInfoImprovementAndRequestHandler
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Adding linter #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c2aa8d.
This reverts commit 3d45da7.
The code is not yet linted, because we should speak about the specific guidelines we'd like to define. That's why the CI build fails, currently. |
Many thanks for submitting this! Although I'm not able to formally start a review as long as the PR is marked as draft, I might just add a preliminary one as a comment here: First of all, generally, this looks good to me. There are a few minor remarks, though:
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out some approaches for linting the code.
Like described in the README.md, the local build will automatically change the code to fulfil the guidelines. The CI build will only make a check and fails if the code style violates the defined guidelines.