Inject an additional element with environment information into the input data in IngestReader #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate method of IngestReader, so it can be overridden in subclasses
test_custom_ingest() - Minor: update the order of the templates in the XSLT according to order of elements in the input
case, always validate against the schema according to the ICAT server version, we are talking to
|
Tested this on a separate branch for case that icatproject/icat.server#231 would be implemented: works. Only remaining TODO is documentation, but for this, I'll wait for #142 to be merged and build on top of that. |
_environment element that is injected into the metadata during that processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional element
_environmentinto the the input metadata after XSD validation and before applying the XSLT in classIngestReader. This environment information may thus be used in the XSLT. Close #148.For the time being, the environment information only consists of the version of the ICAT server, so it's mostly a proof of concept. More attributes may be added in the future.
This still needs documentation and more thorough testing, hence the draft status of the PR.