Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests and documentation on class attributes in IngestReader to configure prescribed values #163

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

RKrahl
Copy link
Member

@RKrahl RKrahl commented Oct 11, 2024

I merged #161 a little bit prematurely, a few more things should have been included:

  • add tests to verify that the values of the new class attributes Dataset_complete and DatasetType_name are indeed properly set in the ingested data,
  • add some more documentation on that new feature, including some caveats,
  • while we are at it, extend the existing test for the _environment element to also add a custom attribute.

@RKrahl RKrahl added documentation Improvements or additions to documentation test suite Issues related with the test suite labels Oct 11, 2024
@RKrahl RKrahl added this to the 1.5.0 milestone Oct 11, 2024
@RKrahl RKrahl changed the title More tests and documentation on class attributes to IngestReader to configure prescribed values More tests and documentation on class attributes in IngestReader to configure prescribed values Oct 11, 2024
@RKrahl RKrahl merged commit 899934f into develop Oct 11, 2024
1 check passed
@RKrahl RKrahl deleted the ingest-transform-config branch October 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test suite Issues related with the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant