Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ion sync upstream #2

Merged
merged 63 commits into from
Jul 9, 2024
Merged

Ion sync upstream #2

merged 63 commits into from
Jul 9, 2024

Conversation

ice-proteus
Copy link
Collaborator

No description provided.

neodix42 and others added 30 commits March 12, 2024 19:11
* Add standalone emulator.so/dylyib/dll to release artifacts

* sync emulator names
* fix windows build

* exclude test-bigint execution on windows

---------

Co-authored-by: My Name <[email protected]>
* 3.6. Fix directory traversal in KeyValueDir

* 3.9. Fix buffer_to_hex reversing nibbles

* 3.5. Fix error handling at blocks.getBlockHeader

* 3.11. Fix query.forget

* 3.12. Fix error handling in RemoteRunSmcMethod

* 4.1. Delete unused files

* 3.10. Use named constants instead hardcoded constants

* 3.4. Fix response block header verification

* 3.1. Check proof of blocks.getShards response

* fix td::buffer_to_hex + test

* 3.2. Add proof check for listBlockTransactions response in RunEmulator actor

* 3.8. Add proof checking for getLibraries method

* fix regression tests

* 3.3 Add proof checking for lookupBlock method

* Add publishers to proof of getLibrariesWithProof response  (ton-blockchain#25)

* fix missing return, fix requesting mc block

* Fix requesting lookupBlock with client mc blk == mc ref block

* Fix duplicating lib data in proof and data, add mode 2 for not including the data

* Migration of LastBlockStorage with fixed td::buffer_to_hex

---------

Co-authored-by: ms <[email protected]>
Co-authored-by: Marat <[email protected]>
* Save rocksdb statistics to file every minute

* Add flag to disable collecting rocksdb statistics
* Compress block candidates in validator-session

* Compress blocks in full-node (disabled for now)

---------

Co-authored-by: SpyCheese <[email protected]>
* fix typos

* fix typo
* Statistics for .pack files

* optimizations

* fix typo

* fix erasing packages
* Compress block candidates in validator-session

* Compress blocks in full-node (disabled for now)

* test pipeline with lz4

* tonlib compilation required lz4;
try win compile;

* install lz4 on mac.

* wip, test builds

* remove FindLZ4.cmake

* fix typo

* fix wasm lz4 path

* increase groovy timeout to 120 sec

* add lz4 for android and emscripten builds

* add lz4 for android and emscripten builds

* fix win build include path for lz4

* add precompiled lz4 for android

* cleanup

* adjust android include dir for lz4

* fix path for android arm of lz4

* cleanup

* minor fix

---------

Co-authored-by: SpyCheese <[email protected]>
* Private overlay for external messages

* Improve ext msg overlays

* Manage from validator console
* Bypass out queue size limit for high-priority messages
* Shuffle messages in get_external_messages

* Cleanup mempool when creating validator group

* Improve private overlays for externals

1. Allow using validator adnl ids in addition to fullnode ids
2. Set priority per sender, not per overlay
3. Require the same overlay name for all nodes
4. Enable lz4 in private block overlay

* Fix typo, add debug logs

* Enable lz4 in private block overlay by config

Change proto_version for lz4 in catchain overlays to 4

* Add logs for broadcasts in fullnode

---------

Co-authored-by: SpyCheese <[email protected]>
This leaves only 3 last temp packages

Co-authored-by: SpyCheese <[email protected]>
EmelyanenkoK and others added 19 commits May 14, 2024 17:11
* Broadcast shardchain block candidates in private overlays, generate proof links from candidates

* Disable shardchain block broadcasts in private overlays

* Send block candidate broadcasts to custom overlays, allow non-validators to receive candidates

---------

Co-authored-by: SpyCheese <[email protected]>
* use jemalloc

* install system jemalloc in github action

* check if jemalloc is actually used

---------

Co-authored-by: neodiX <[email protected]>
* Limit checked external messages per address

* Change max_ext_msg_per_addr_time_window; cleanup mempool by timer

---------

Co-authored-by: SpyCheese <[email protected]>
…ockchain#1012)

* Rollback celldb default flag values and decrease default TTLs

* Fix description
…in#1014)

* add github action for macOS 14 (arm64, M1)

* add github action (portable) for macOS 14 (arm64, M1)

* rename macOS arm64 output artifact

* Colon cannot be used as a path separator for FIFTPATH or -I argument in fift on Windows when absolute paths are used (e.g. C:\path\lib:C:\path\smartcont).
Suggestion to use @ as a new path separator on Windows.

---------

Co-authored-by: neodiX <[email protected]>
* use jemalloc in portable builds;
also avoid mixing musl with glibc artifacts in nix builds;

* minor fix for ubuntu arm nix build
…ckchain#1001)

* add github action for macOS 14 (arm64, M1)

* add github action (portable) for macOS 14 (arm64, M1)

* rename macOS arm64 output artifact
@ice-charon
Copy link
Collaborator

@ice-proteus can you resolve conflicts in the hidden folder .github on top level branch.

@ice-proteus
Copy link
Collaborator Author

ice-proteus commented Jun 20, 2024 via email

@ice-charon
Copy link
Collaborator

ice-charon commented Jun 20, 2024

Hey @ice-proteus you can see below review requested there is running tests, below them there is unresolved conflicts.
Usually you have to fetch master and merge it over your branch

git fetch origin master
git merge FETCH_HEAD

Then you have to force push changes.
You can experimenting, if you have problems I can do it for you.
Also can you change this line https://github.com/ice-blockchain/ion/blob/master/crypto/CMakeLists.txt#L565 to

share/ion

That's why 4 tests are unsuccessful.

@ice-proteus
Copy link
Collaborator Author

ice-proteus commented Jun 21, 2024 via email

@ice-charon
Copy link
Collaborator

Ok, I see. I changed the line from crypto/CMakeLists.txt to share/ion. I see that the conflicts from the .github folder involve some extra libraries. Resolving the conflicts would mean keeping these extra libraries?

Correct.

Windows build is broken because of MSVC is version 19.40.33811.0 which based on this calculation
https://github.com/ice-blockchain/ion/blob/master/CMake/FindSodium.cmake#L128-L133
is 1940 / 10 - 50 = 144 but in libsodium there is no v144 directory, there is v142 and v143 so we need a one version older Windows machine, @ice-hermes

@ice-hermes ice-hermes merged commit 2366e24 into master Jul 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants