adding DAEMONFLUX stage #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2023 01:40
…(did not try to ad it to setup.py since MCEq is not included anyway and I don't want to break stuff); also tested daemon stage in calc_grid mode (no modifications needed for it to work)
|
Looks good to me, but I didn't check the details of the stage itself. The discrepancies that @anilak41 is seeing are confirmed with this stage and with the pure python daemonflux, right? So I assume this is unrelated to the implementation of the stage? And apart from the notebook there is no more detailed explanations than the paper itself? |
LeanderFischer
approved these changes
Feb 2, 2024
|
I have used this daemon flux stage and checked the DAEMON flux, which looks consistent with the one obtained using daemonflux python library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's finnaly time to merge this into master...
Summary: I added daemonflux stage and a simple example notebook + cfg file (see https://arxiv.org/abs/2303.00022). Also updated flux readme as well as INSTALL.md to mention that daemonflux is now a dependency for this stage.