Skip to content

Commit

Permalink
Make pin widget Fill parent by default
Browse files Browse the repository at this point in the history
  • Loading branch information
hecrj committed Nov 22, 2024
1 parent 5be1d54 commit a805177
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
4 changes: 2 additions & 2 deletions examples/layout/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -319,11 +319,11 @@ fn pinning<'a>() -> Element<'a, Message> {
"The pin widget can be used to position a widget \
at some fixed coordinates inside some other widget.",
stack![
container(pin("• (50, 50)").width(Fill).height(Fill).x(50).y(50))
container(pin("• (50, 50)").x(50).y(50))
.width(500)
.height(500)
.style(container::bordered_box),
pin("• (300, 300)").width(Fill).height(Fill).x(300).y(300),
pin("• (300, 300)").x(300).y(300),
]
]
.align_x(Center)
Expand Down
2 changes: 0 additions & 2 deletions widget/src/helpers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,6 @@ where
///
/// fn view(state: &State) -> Element<'_, Message> {
/// pin("This text is displayed at coordinates (50, 50)!")
/// .width(Fill)
/// .height(Fill)
/// .x(50)
/// .y(50)
/// .into()
Expand Down
10 changes: 4 additions & 6 deletions widget/src/pin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
//!
//! fn view(state: &State) -> Element<'_, Message> {
//! pin("This text is displayed at coordinates (50, 50)!")
//! .width(Fill)
//! .height(Fill)
//! .x(50)
//! .y(50)
//! .into()
Expand All @@ -33,6 +31,8 @@ use crate::core::{

/// A widget that positions its contents at some fixed coordinates inside of its boundaries.
///
/// By default, a [`Pin`] widget will try to fill its parent.
///
/// # Example
/// ```no_run
/// # mod iced { pub mod widget { pub use iced_widget::*; } pub use iced_widget::core::Length::Fill; }
Expand All @@ -47,8 +47,6 @@ use crate::core::{
///
/// fn view(state: &State) -> Element<'_, Message> {
/// pin("This text is displayed at coordinates (50, 50)!")
/// .width(Fill)
/// .height(Fill)
/// .x(50)
/// .y(50)
/// .into()
Expand All @@ -75,8 +73,8 @@ where
) -> Self {
Self {
content: content.into(),
width: Length::Shrink,
height: Length::Shrink,
width: Length::Fill,
height: Length::Fill,
position: Point::ORIGIN,
}
}
Expand Down

0 comments on commit a805177

Please sign in to comment.