Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of nested markdown lists without empty line #2641

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Jinderamarak
Copy link
Contributor

@Jinderamarak Jinderamarak commented Oct 16, 2024

Fixes #2640.

This change aligns the rendering of markdown more closely with other products (github, preview.md, etc.).

Testing markdown:

**Expected**

- first
- second

    - nested first
    - nested second

- third


**Actual**

- first
- second
    - nested first
    - nested second
- third


**Third**

- first
-
    - nested first
    - nested second
- third

Github

Expected

  • first

  • second

    • nested first
    • nested second
  • third

Actual

  • first
  • second
    • nested first
    • nested second
  • third

Third

  • first
    • nested first
    • nested second
  • third

Iced

image

@hecrj hecrj added this to the 0.14 milestone Jan 15, 2025
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@hecrj hecrj force-pushed the fix-markdown-nested-lists branch from 5e7faec to 440918c Compare January 15, 2025 10:59
@hecrj hecrj enabled auto-merge January 15, 2025 10:59
@hecrj hecrj merged commit a00f564 into iced-rs:master Jan 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of nested lists in markdown
2 participants