Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iced::window::run_with_window_handles for usage e.g. with rfd 0.15+ #2718

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flakes
Copy link

@flakes flakes commented Jan 4, 2025

Based on

  • several discussions on Discord and rfd for file dialogs #1002
  • the latest update to rfd which took away the auto-parent selection for asynchronous rfd dialogs on MacOS

I decided to give this a chance. There's a few rough edges, specifically:

  • naming and placement of the new structure WindowHandles
  • there's no way to start another task from within the closure that is passed to run_with_window_handles, so we can't use async code without another intermediate Message
  • usage of unwrap()
  • removal of run_with_handle (?)

All comments welcome :-)

@flakes flakes force-pushed the new-rfd-and-windowhandles branch from 4f94cdb to 9bfd0d1 Compare January 4, 2025 20:03
@flakes flakes marked this pull request as draft January 5, 2025 20:49
@flakes flakes force-pushed the new-rfd-and-windowhandles branch from 9bfd0d1 to 254495f Compare January 7, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant