-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant conditional #590
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #590 +/- ##
===============================================
+ Coverage 66.68% 66.76% +0.07%
===============================================
Files 36 36
Lines 3077 3075 -2
Branches 594 593 -1
===============================================
+ Hits 2052 2053 +1
+ Misses 935 933 -2
+ Partials 90 89 -1 ☔ View full report in Codecov by Sentry. |
@@ -393,8 +393,6 @@ def build_params(self, **kwargs): | |||
self._fmted_keys.update({key: kwargs[key]}) | |||
except KeyError: | |||
self._fmted_keys.update({key: kwargs["product"]}) | |||
elif key == "version": | |||
self._fmted_keys.update({key: kwargs["version"]}) | |||
elif key in kwargs: | |||
self._fmted_keys.update({key: kwargs[key]}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For key == "version"
, this branch does the same thing as the removed branch.
This conditional is handled by the next one in the chain.