Add some TODOs and commented-out wip code

icosa-foundation · Nov 13, 2024 · 430e328 · 430e328
1 parent a051f12
commit 430e328
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/Assets/Scripts/Poly/IcosaAssetCatalog.cs b/Assets/Scripts/Poly/IcosaAssetCatalog.cs
@@ -826,6 +826,7 @@ void LoadModelsInQueueAsync()
                 Model model = m_LoadQueue[i].Model;
                 model.LoadModel();
                 // TODO Back to async loading
+                // AsyncHelpers.RunSync(model.LoadModelAsync);
                 m_LoadQueue.RemoveAt(i);
                 m_IsLoadingMemo = null;
                 m_NotifyListeners = true;

diff --git a/Assets/Scripts/Sharing/VrAssetService.cs b/Assets/Scripts/Sharing/VrAssetService.cs
@@ -839,13 +839,17 @@ public AssetLister ListAssets(SketchSetType type)
                     {
                         return null;
                     }
+                    // TODO Filter out non-remixable assets
+                    // filteredUriPath = CombineQueryParams(kUserLikesUri, "format=TILT&orderBy=LIKED_TIME&license=CREATIVE_COMMONS_BY");
                     filteredUriPath = CombineQueryParams(kUserLikesUri, "format=TILT&orderBy=LIKED_TIME");
                     errorMessage = "Failed to access your liked sketches.";
                     break;
                 case SketchSetType.Curated:
                     // Old way - newest curated
                     // filteredUriPath = CombineQueryParams(kListAssetsUri, "format=TILT&curated=true&orderBy=NEWEST");
                     // For now try just sorting by "best"
+                    // TODO Filter out non-remixable assets
+                    // filteredUriPath = CombineQueryParams(kListAssetsUri, "format=TILT&orderBy=BEST&license=CREATIVE_COMMONS_BY");
                     filteredUriPath = CombineQueryParams(kListAssetsUri, "format=TILT&orderBy=BEST");
                     errorMessage = "Failed to access featured sketches.";
                     break;
@@ -892,6 +896,8 @@ public AssetLister ListAssets(IcosaSetType type)
             switch (type)
             {
                 case IcosaSetType.Liked:
+                    // TODO Filter out non-remixable assets
+                    // uri += $"{kUserLikesUri}?orderBy=LIKED_TIME&license=CREATIVE_COMMONS_BY";
                     uri += $"{kUserLikesUri}?orderBy=LIKED_TIME";
                     break;
                 case IcosaSetType.User:
@@ -901,6 +907,8 @@ public AssetLister ListAssets(IcosaSetType type)
                     // Old way - newest curated
                     // uri += $"{kListAssetsUri}" + $"?curated=true&orderBy=NEWEST";
                     // For now try just sorting by "best"
+                    // TODO Filter out non-remixable assets
+                    // uri += $"{kListAssetsUri}" + $"?orderBy=BEST&license=CREATIVE_COMMONS_BY";
                     uri += $"{kListAssetsUri}" + $"?orderBy=BEST";
                     // Something like orderBy=TRENDING would be good - BEST but weighted by recency
                     break;