Basic Multiplayer UI #774
Draft
Basic Multiplayer UI #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will probably conflict # Conflicts: # Assets/Scenes/Main.unity
# Conflicts: # Assets/Scripts/Multiplayer/MultiplayerInterfaces.cs # Assets/Scripts/Multiplayer/MultiplayerManager.cs
# Conflicts: # Assets/Scripts/PassthroughManager.cs
[CI BUILD]
# Conflicts: # Assets/Settings/Localization/Strings/Strings Shared Data.asset # Assets/Settings/Localization/Strings/Strings_en.asset
# Conflicts: # Assets/Settings/Localization/Strings/Strings_en.asset
-Implemented global command: MultiplayerJoinRoom. -Updated the multiplayer panel prefab and manager. -Changed the admin panel layout from hexagon to octagon. TODO: -Add room name editing capabilities.
…open-brush into multiplayer/ui
- Added initialization of the keyboard with the current room name in `MultiplayerPanelButton.cs`. - Changed `SetRoomName` to a property (`RoomName`) in `MultiplayerPanel.cs` for better readability and encapsulation. - Updated `SketchControlScript.cs` to use the new `RoomName` property.
-MultiplayerManager: Added DoesRoomNameExist() and updated m_RoomData for room validation. -MultiplayerPanel: Added UpdateRoomExistenceMessage() to indicate if a room exists or will be created (added a text to the prefab)
remove 'GraphView'
andybak
commented
Oct 8, 2024
Clear scene for non-room owner players on join: If a player joins and is not the room owner, their scene is reset to ensure consistency with the room owner's state upon receiving the synchronized history.
Remote players were not correctly registered when already present in the room because `INetworkRunnerCallbacks.OnPlayerJoined` in Fusion 1 is not called for users who are already in the room. To address this, we added and registered existing users using the `CheckExistingUsers()` method. Additionally, in `MultiplayerManager.cs`, the local player ID was not registered correctly, which has now been fixed. A display for both the local and remote user IDs was added to `MultiplayerManagerEditor.cs` to facilitate debugging.
Fixed issue where remote user list was not cleared on disconnect or room exit.
Enhanced MultiplayerManager Editor to streamline debugging with clearer information display and controls.
This update refactors `SendCommandHistory` to use a coroutine, sending commands in batches with a delay between each batch. This approach reduces the likelihood of Photon RPC message delivery failures that occur when too many messages are sent within the same frame. The coroutine yields between batches and includes a configurable delay to ensure smooth, reliable transmission over the network.
Add support for initializing commands with existing GUIDs Check memory script stack for guid commands before performing the command
To correctly define who is the room owner beyond the two users case we need to share this property, we do this by extending the PhotonPlayerRig NetworkBehaviour component
sbanca
force-pushed
the
multiplayer/ui
branch
from
ac4c240
to
00033e2
Compare
…open-brush into multiplayer/ui
Taking care of few edge cases and cleaning logs
Removing the Connect and Disconnect buttons and extending the MultiplayerPanel.cs to connect when enabled. If the user is not in the room, it will disconnect when disabled.
Added a RoomOwnershipUpdated action to MultiplayerManager.cs to send updates about room ownership to the multiplayer UI panel. Updated the MultiplayerPanel script and prefab to include a Room Ownership field.
sbanca
force-pushed
the
multiplayer/ui
branch
from
0ec9c14
to
b38b663
Compare
Fix null reference issues in PhotonPlayerRig by adding checks for destroyed objects in RecieveData and other methods.
Clamped SceneScale to prevent division by zero or extremely small values.
Updating the languages translations for the Multiplayer UI
Updated the PhotonPlayerRig prefab to properly manage dummy transforms and model transforms for left/right controllers.
removing redundant commented code
- Introduced m_IsSpawned flag in PhotonPlayerRig to track spawn state. - Updated ReceiveData() to check m_IsSpawned before accessing IsRoomOwner, avoiding InvalidOperationException. - Set m_IsSpawned to false in OnDestroy() to handle object despawning. - Added warning logs for attempts to access networked properties post-despawn, aiding in debugging.
Extended CanRedo() and CanUndo() methods in SketchControlScript to include a condition checking if the connection state is IN_ROOM, preventing undo/redo functionality when in multiplayer mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.