Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so that BorderForMouseOver of Line control is displayed at correct position #116

Conversation

YuuukiA
Copy link
Contributor

@YuuukiA YuuukiA commented Oct 15, 2024

Workaround for #115

@YuuukiA
Copy link
Contributor Author

YuuukiA commented Oct 15, 2024

@jogibear9988
Hello,
Would you please check this?

if (ExtendedItem.Component is Line line)
{
// To display border of Line in correct position.
border.Margin = new Thickness
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the extended item isn't a line, don't you need to reset the margin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't think it is needed.

It is because instance of BorderForMouseOver is re-created when mouse over other item.

@jogibear9988 jogibear9988 merged commit 88127f7 into icsharpcode:master Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants