Skip to content

Commit

Permalink
Sankey bug fixes (#248)
Browse files Browse the repository at this point in the history
* Fixed nodes going off the left hand side

* Improved the layout a little

* Progress save

* Added key states toggle

* Made distribution bars black

* Updates and fixes

* Made the dist handle color less intense

* Fixed combined mean and standard deviation

* Standard deviation fix

* Added missing info to links

* Hover effect for bars & other improvements
  • Loading branch information
nmde authored Mar 8, 2023
1 parent 43223e5 commit 4a92a9f
Show file tree
Hide file tree
Showing 11 changed files with 355 additions and 227 deletions.
6 changes: 6 additions & 0 deletions EMRALD_Sim/sankey/emrald-sankey-timeline.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
#chart {
display: block;
}

#keyStateOptions {
bottom: 0;
position: fixed;
}
</style>
</head>
<body>
Expand All @@ -29,6 +34,7 @@
<button id="zoomIn">Zoom In</button>
<button id="save">Save</button>
<svg id="chart"></svg>
<div id="keyStateOptions"></div>
<script src="./data.js"></script>
<script src="./emrald-sankey-timeline.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion EMRALD_Sim/sankey/emrald-sankey-timeline.js

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions Emrald_Site/sankey/emrald-sankey-timeline.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
#chart {
display: block;
}

#keyStateOptions {
bottom: 0;
position: fixed;
}
</style>
</head>
<body>
Expand All @@ -29,6 +34,7 @@
<button id="zoomIn">Zoom In</button>
<button id="save">Save</button>
<svg id="chart"></svg>
<div id="keyStateOptions"></div>
<script src="./data.js"></script>
<script src="./emrald-sankey-timeline.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion Emrald_Site/sankey/emrald-sankey-timeline.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Emrald_Site/scripts/UI/simApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ function openSankey() {
const wnd = mxWindow.createFrameWindow(
'sankey/emrald-sankey-timeline.html',
'OK',
'close',
'minimize, maximize, close',
(btn) => {
if (btn === 'OK') {
console.log('OK');
Expand Down
6 changes: 6 additions & 0 deletions d3-sankey-timeline/emrald-sankey-timeline.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
#chart {
display: block;
}

#keyStateOptions {
bottom: 0;
position: fixed;
}
</style>
</head>
<body>
Expand All @@ -29,6 +34,7 @@
<button id="zoomIn">Zoom In</button>
<button id="save">Save</button>
<svg id="chart"></svg>
<div id="keyStateOptions"></div>
<script src="./data.js"></script>
<script src="./emrald-sankey-timeline.js"></script>
<script>
Expand Down
Loading

0 comments on commit 4a92a9f

Please sign in to comment.