Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for using flexible assembly patterning with AssemblyMeshGenerator as the final generator #29827

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

shikhar413
Copy link
Contributor

@shikhar413 shikhar413 commented Feb 6, 2025

Reason

Design

Impact

refs #29826

GiudGiud
GiudGiud previously approved these changes Feb 6, 2025
@GiudGiud GiudGiud self-assigned this Feb 6, 2025
@GiudGiud GiudGiud dismissed their stale review February 7, 2025 00:06

a test fail

@moosebuild
Copy link
Contributor

moosebuild commented Feb 7, 2025

Job Documentation, step Docs: sync website on a7db00e wanted to post the following:

View the site here

This comment will be updated on new commits.

@shikhar413 shikhar413 force-pushed the rgmb_flexible_patterning_patch branch 2 times, most recently from 2faf2f7 to 6935fb9 Compare February 7, 2025 14:59
@shikhar413 shikhar413 force-pushed the rgmb_flexible_patterning_patch branch from 6935fb9 to a7db00e Compare February 7, 2025 16:42
@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on a7db00e wanted to post the following:

Framework coverage

93913d #29827 a7db00
Total Total +/- New
Rate 85.28% 85.29% +0.00% -
Hits 108338 108342 +4 0
Misses 18697 18693 -4 0

Diff coverage report

Full coverage report

Modules coverage

Reactor

93913d #29827 a7db00
Total Total +/- New
Rate 93.67% 93.67% +0.00% 100.00%
Hits 7742 7743 +1 1
Misses 523 523 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud
Copy link
Contributor

GiudGiud commented Feb 7, 2025

test failures (web server, a fvik, a dirac kernel an auxkernel timeout) all unrelated

@GiudGiud GiudGiud merged commit 18f4ece into idaholab:next Feb 7, 2025
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants