Optional ReplyKeyboardMarkup creation depending on specific #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eplyKeyboardMarkup instead of InlineKeyboardMarkup for Telegram bridge
idchlife
requested changes
Apr 26, 2023
| nil if keyboard_object.nil? || !keyboard_object.to_a.count.positive? | ||
|
|
||
| inline_keyboard = [] | ||
| if output.specifics.has?(:tg_reply_keyboard) == false || output.specifics.get(:tg_reply_keyboard) == false |
There was a problem hiding this comment.
Check for :tg_reply_keyboard == true
in this case - use reply keyboard
Otherwise, use inline keyboard by default
And only one check for get == nil is sufficient
idchlife
requested changes
Apr 26, 2023
| @@ -66,34 +66,34 @@ def setup | |||
| output_convert :keyboard, :tg_reply_markup do |keyboard_object, input, output| | |||
| nil if keyboard_object.nil? || !keyboard_object.to_a.count.positive? | |||
|
|
|||
| if output.specifics.has?(:tg_reply_keyboard) == false || output.specifics.get(:tg_reply_keyboard) == false | |||
| inline_keyboard = [] | |||
| if output.specifics.get :tg_reply_keyboard | |||
There was a problem hiding this comment.
Better check explicitly for true because any object or something passed here will be considered truthy. Only falsy values are false, nil.
Just in case. I doubt there will be the case but just to be sure we won't have any side effects
| else | ||
| regular_keyboard = [] | ||
| inline_keyboard = [] |
There was a problem hiding this comment.
This whole if/else code can be refactored to reduce copypaste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.