adding transaction id and transmission id

[ymhari]

https://www.pivotaltracker.com/story/show/187936511

Summary by CodeRabbit

• New Features

  • Enhanced transaction hash creation by including a transaction_id.

• Bug Fixes

  • Improved accuracy in generating individual payloads by using correlation_id instead of transmission_id.

• Tests

  • Added tests to ensure transaction_id is correctly handled and validated.

[coderabbitai]

Walkthrough

The changes enhance transaction processing by adding a transaction_id to the build_transaction_hash function and modifying the create_transmission method to use correlation_id instead of transmission_id. Additionally, tests were updated to reflect these new parameters.

Changes

Files	Change Summary
app/operations/fdsh/jobs/create_transaction.rb	Enhanced build_transaction_hash function to include transaction_id.
app/operations/fdsh/jobs/generate_individual_dmf_payload.rb	Modified create_transmission method to use correlation_id instead of transmission_id.
spec/operations/fdsh/jobs/create_transaction_spec.rb	Added transaction_id to optional_params and updated test assertions to check equality with encrypted_ssn.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CreateTransaction
    participant GenerateIndividualDmfPayload
    participant FdshJobs

    User->>CreateTransaction: Call build_transaction_hash(values, transaction_id)
    CreateTransaction->>CreateTransaction: Add transaction_id to hash
    CreateTransaction-->>User: Return transaction hash

    User->>GenerateIndividualDmfPayload: Call create_transmission(values)
    GenerateIndividualDmfPayload->>FdshJobs: CreateTransmission.new.call(correlation_id: family_hbx_id)
    FdshJobs-->>GenerateIndividualDmfPayload: Transmission created
    GenerateIndividualDmfPayload-->>User: Return result

Loading

Poem

In lines of code, the changes flow,
transaction_id now we bestow.
Correlation takes its rightful stand,
To streamline flows across the land.
Tests align with seamless grace,
A better system, in its place.
🎉🐇🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 07be66f and 476f24f.

Files selected for processing (3)

• app/operations/fdsh/jobs/create_transaction.rb (1 hunks)
• app/operations/fdsh/jobs/generate_individual_dmf_payload.rb (1 hunks)
• spec/operations/fdsh/jobs/create_transaction_spec.rb (2 hunks)

Additional comments not posted (4)

app/operations/fdsh/jobs/create_transaction.rb (1)

36-36: Ensure transaction_id parameter is passed correctly.

The transaction_id parameter is correctly added to the build_transaction_hash method. Verify that all calls to this method pass the transaction_id parameter to prevent potential issues.

spec/operations/fdsh/jobs/create_transaction_spec.rb (2)

26-27: Test coverage for transaction_id looks good.

The transaction_id is correctly added to the optional_params. Ensure that all relevant test cases include this parameter to verify the new functionality comprehensively.

---

119-119: Assertion for transaction_id verification is correct.

The assertion correctly checks that transaction_id equals person_subject.encrypted_ssn. This ensures that the new functionality is properly validated.

app/operations/fdsh/jobs/generate_individual_dmf_payload.rb (1)

38-38: Ensure correlation_id parameter is passed correctly.

The correlation_id is correctly added to the create_transmission method. Verify that all calls to this method pass the correlation_id parameter to prevent potential issues.