Skip to content

Commit

Permalink
Merge pull request #235 from shuoer86/master
Browse files Browse the repository at this point in the history
Fix typos
  • Loading branch information
clararod9 authored Mar 29, 2024
2 parents 3528694 + dd51db6 commit 207a712
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ impl WriteC for CreateCmpBucket {
}
}
// generate array with the positions that are actually created if there are empty components
// if not only traverse the defined positions, but i gets the value of the indexed accesed position
// if not only traverse the defined positions, but i gets the value of the indexed accessed position
else{
instructions.push(format!("uint aux_positions [{}]= {};", self.defined_positions.len(), set_list(self.defined_positions.iter().map(|(x, _y)| *x).collect())));
instructions.push(format!("for (uint i_aux = 0; i_aux < {}; i_aux++) {{", self.defined_positions.len()));
Expand Down Expand Up @@ -302,4 +302,4 @@ impl WriteC for CreateCmpBucket {
instructions.push("}".to_string());
(instructions, "".to_string())
}
}
}
4 changes: 2 additions & 2 deletions constraint_generation/src/execute.rs
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ fn execute_signal_declaration(
}

/*
In case the assigment could be a constraint generator the returned value is the constraint
In case the assignment could be a constraint generator the returned value is the constraint
that will be created
*/
struct Constrained {
Expand Down Expand Up @@ -2488,4 +2488,4 @@ fn add_report_to_runtime(
}
report.add_note(trace);
runtime_errors.push(report);
}
}
2 changes: 1 addition & 1 deletion mkdocs/docs/circom-language/formats/simplification-json.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ to indicate that we do not want to apply any simplification, the generated file
{
}
```
Finaly, if we run
Finally, if we run

```text
circom simplify.circom --r1cs --wasm --simplification_substitution --O1
Expand Down
2 changes: 1 addition & 1 deletion mkdocs/docs/circom-language/formats/sym.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ to indicate that we do not want to apply any simplification the generated file '
5,5,0,main.c.in[0]
6,6,0,main.c.in[1]
```
Finaly, if we run
Finally, if we run

```text
circom symbols.circom --r1cs --wasm --sym --O1
Expand Down
2 changes: 1 addition & 1 deletion mkdocs/docs/circom-language/tags.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ The input array `in` is declared with the tag `binary`. This tag means that each

Then, whenever the previous template is instantiated, the compiler checks if the array `a` assigned to the input array has the tag binary, since `in` has the tag `binary` in its declaration. If it does not, an error is reported. Notice that the compiler also checks if both arrays have the same size.

It is important to highlight that the compiler does never make any check about the validity of the tags. It is the programmer's responsibility to include the constraints and executable code to guarantee that the inteded meaning of each signal is always true.
It is important to highlight that the compiler does never make any check about the validity of the tags. It is the programmer's responsibility to include the constraints and executable code to guarantee that the intended meaning of each signal is always true.

When doing a substitution from a tagged signal to another signal, the tags are always inherited by it (even if it is not declared with it). For instance,

Expand Down

0 comments on commit 207a712

Please sign in to comment.