Skip to content

Commit

Permalink
Fix linter
Browse files Browse the repository at this point in the history
  • Loading branch information
Andriian Chestnykh committed Jan 29, 2024
1 parent 9aa8fe7 commit 566fcd1
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 35 deletions.
9 changes: 3 additions & 6 deletions contracts/validators/CredentialAtomicQueryMTPValidator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,9 @@ contract CredentialAtomicQueryMTPValidator is CredentialAtomicQueryValidator {
return params;
}

function _getSpecialInputPairs(bool hasSelectiveDisclosure)
internal
pure
override
returns (ICircuitValidator.KeyInputIndexPair[] memory)
{
function _getSpecialInputPairs(
bool hasSelectiveDisclosure
) internal pure override returns (ICircuitValidator.KeyInputIndexPair[] memory) {
ICircuitValidator.KeyInputIndexPair[]
memory pairs = new ICircuitValidator.KeyInputIndexPair[](2);
pairs[0] = ICircuitValidator.KeyInputIndexPair({key: "userID", inputIndex: 1});
Expand Down
9 changes: 3 additions & 6 deletions contracts/validators/CredentialAtomicQuerySigValidator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,9 @@ contract CredentialAtomicQuerySigValidator is CredentialAtomicQueryValidator {
return params;
}

function _getSpecialInputPairs(bool hasSelectiveDisclosure)
internal
pure
override
returns (ICircuitValidator.KeyInputIndexPair[] memory)
{
function _getSpecialInputPairs(
bool hasSelectiveDisclosure
) internal pure override returns (ICircuitValidator.KeyInputIndexPair[] memory) {
ICircuitValidator.KeyInputIndexPair[]
memory pairs = new ICircuitValidator.KeyInputIndexPair[](2);
pairs[0] = ICircuitValidator.KeyInputIndexPair({key: "userID", inputIndex: 1});
Expand Down
23 changes: 14 additions & 9 deletions contracts/validators/CredentialAtomicQueryV3Validator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,9 @@ contract CredentialAtomicQueryV3Validator is CredentialAtomicQueryValidator {
_checkAuth(signals.userID, sender);
}

ICircuitValidator.KeyInputIndexPair[] memory pairs = _getSpecialInputPairs(credAtomicQuery.operator == 16);
ICircuitValidator.KeyInputIndexPair[] memory pairs = _getSpecialInputPairs(
credAtomicQuery.operator == 16
);
bytes memory encodedPairs = abi.encode(pairs);
uint256 epLength = encodedPairs.length;

Expand Down Expand Up @@ -256,12 +258,9 @@ contract CredentialAtomicQueryV3Validator is CredentialAtomicQueryValidator {
return pubSignals;
}

function _getSpecialInputPairs(bool hasSelectiveDisclosure)
internal
pure
override
returns (ICircuitValidator.KeyInputIndexPair[] memory)
{
function _getSpecialInputPairs(
bool hasSelectiveDisclosure
) internal pure override returns (ICircuitValidator.KeyInputIndexPair[] memory) {
uint256 numPairs = hasSelectiveDisclosure ? 7 : 6;
ICircuitValidator.KeyInputIndexPair[]
memory pairs = new ICircuitValidator.KeyInputIndexPair[](numPairs);
Expand All @@ -271,11 +270,17 @@ contract CredentialAtomicQueryV3Validator is CredentialAtomicQueryValidator {
pairs[i++] = ICircuitValidator.KeyInputIndexPair({key: "linkID", inputIndex: 4});
pairs[i++] = ICircuitValidator.KeyInputIndexPair({key: "nullifier", inputIndex: 5});
if (hasSelectiveDisclosure) {
pairs[i++] = ICircuitValidator.KeyInputIndexPair({key: "operatorOutput", inputIndex: 6});
pairs[i++] = ICircuitValidator.KeyInputIndexPair({
key: "operatorOutput",
inputIndex: 6
});
}
pairs[i++] = ICircuitValidator.KeyInputIndexPair({key: "timestamp", inputIndex: 14});
pairs[i++] = ICircuitValidator.KeyInputIndexPair({key: "verifierID", inputIndex: 15});
pairs[i++] = ICircuitValidator.KeyInputIndexPair({key: "nullifierSessionID", inputIndex: 16});
pairs[i++] = ICircuitValidator.KeyInputIndexPair({
key: "nullifierSessionID",
inputIndex: 16
});

return pairs;
}
Expand Down
14 changes: 7 additions & 7 deletions contracts/validators/CredentialAtomicQueryValidator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ abstract contract CredentialAtomicQueryValidator is OwnableUpgradeable, ICircuit
uint256[2] calldata c,
bytes calldata data,
address sender
) internal view virtual returns (ICircuitValidator.KeyInputIndexPair[] memory) {
) internal view virtual returns (ICircuitValidator.KeyInputIndexPair[] memory) {
CredentialAtomicQuery memory credAtomicQuery = abi.decode(data, (CredentialAtomicQuery));
IVerifier verifier = _circuitIdToVerifier[credAtomicQuery.circuitIds[0]];

Expand Down Expand Up @@ -148,7 +148,9 @@ abstract contract CredentialAtomicQueryValidator is OwnableUpgradeable, ICircuit
credAtomicQuery.skipClaimRevocationCheck
);

ICircuitValidator.KeyInputIndexPair[] memory pairs = _getSpecialInputPairs(credAtomicQuery.operator == 16);
ICircuitValidator.KeyInputIndexPair[] memory pairs = _getSpecialInputPairs(
credAtomicQuery.operator == 16
);
bytes memory encodedPairs = abi.encode(pairs);
uint256 epLength = encodedPairs.length;

Expand Down Expand Up @@ -260,9 +262,7 @@ abstract contract CredentialAtomicQueryValidator is OwnableUpgradeable, ICircuit
_inputNameToIndex[inputName] = ++index; // increment index to avoid 0
}

function _getSpecialInputPairs(bool hasSelectiveDisclosure)
internal
pure
virtual
returns (ICircuitValidator.KeyInputIndexPair[] memory);
function _getSpecialInputPairs(
bool hasSelectiveDisclosure
) internal pure virtual returns (ICircuitValidator.KeyInputIndexPair[] memory);
}
16 changes: 9 additions & 7 deletions contracts/verifiers/UniversalVerifier.sol
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,11 @@ contract UniversalVerifier is OwnableUpgradeable {
uint256[2] calldata a,
uint256[2][2] calldata b,
uint256[2] calldata c // TODO add bytes calldata additionalData, string calldata circuitId
// string calldata circuitId
// bytes calldata additionalData,
) public requestEnabled(requestId) checkValidatorIsSet(requestId) {
)
public
requestEnabled(requestId)
checkValidatorIsSet(requestId)
{
address sender = _msgSender();
IZKPVerifier.ZKPRequestExtended memory request = _getMainStorage().requests[requestId];

Expand All @@ -235,7 +237,9 @@ contract UniversalVerifier is OwnableUpgradeable {
);

for (uint256 i = 0; i < pairs.length; i++) {
_getMainStorage().proofs[sender][requestId].storageFields[pairs[i].key] = inputs[pairs[i].inputIndex];
_getMainStorage().proofs[sender][requestId].storageFields[pairs[i].key] = inputs[
pairs[i].inputIndex
];
}

_getMainStorage().proofs[msg.sender][requestId].isProved = true;
Expand All @@ -258,9 +262,7 @@ contract UniversalVerifier is OwnableUpgradeable {
IZKPVerifier.ZKPRequestExtended memory request = _getMainStorage().requests[requestId];

// TODO check with standard interface detection here!!!
request.validator.verifyWithSender(
inputs, a, b, c, request.data, _msgSender()
);
request.validator.verifyWithSender(inputs, a, b, c, request.data, _msgSender());
}

/// @notice Gets the proof storage item for a given user, request ID and key
Expand Down

0 comments on commit 566fcd1

Please sign in to comment.