Full Multi-query support onchain

[daveroga]

Implement multi-query support similar to existing requests now in Universal Verifier.

• Manage multi-query (Query) independently and in the same way we are managing Requests in ZKPVerifierBase now (setQuery, getQuery, …). Avoid ZKP and generalize methods in Requests. setRequest, getRequest, submitResponse, …
• Change _proofs mapping from address user to uint256 userID to keep identifier of the user.
• Create 2 mappings for managing link between userAddress and userID . In this first version 1 userID will have only 1 address? Review best approach or if we have to keep an array of addresses.

mapping(address userAddress => uint256 userID) _user_address_to_id;
mapping(unit256 userID => address userAddress) _id_to_user_address; // check address[] ?

• Manage Auth in specific type of requests. Auth requests.

requestId. 32 bytes (in Big Endian): 31-0x00(not used), 30-0x01(requestType), 29..0 hash calculated Id,

For requestType:
   - 0x00 - regular request
   - 0x01 - auth request

• Define challenge based on the ethereum address in this first version
• Figure out linkID between the Requests and Auth of the same Query.
• Consider that more than one type of auth may be available there for specific multiRequest. And each of the multiRequests should define it’s own set of valid auth along with requests.
• RequestId change from uint64 to uint256.

Link to Tech Spec for changes: https://www.notion.so/privado-id/Multi-query-Tech-Spec-13d4f86a875180e68fc8e3fa5362805e

[coveralls]

Pull Request Test Coverage Report for Build 12715993929

Details

• 208 of 260 (80.0%) changed or added relevant lines in 12 files are covered.
• 2 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-1.5%) to 82.517%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contracts/validators/CredentialAtomicQueryV3Validator.sol	13	14	92.86%
contracts/verifiers/ValidatorWhitelist.sol	8	9	88.89%
contracts/validators/AuthV2Validator.sol	0	7	0.0%
contracts/verifiers/EmbeddedVerifier.sol	0	7	0.0%
contracts/validators/EthIdentityValidator.sol	0	13	0.0%
contracts/verifiers/Verifier.sol	155	178	87.08%

Files with Coverage Reduction	New Missed Lines	%
contracts/validators/AuthV2Validator.sol	1	0.0%
contracts/validators/CredentialAtomicQueryValidatorBase.sol	1	76.39%

Totals
Change from base Build 12413543528:	-1.5%
Covered Lines:	1093
Relevant Lines:	1237

---

💛 - Coveralls

[AndriianChestnykh]

I haven't completed review of all the files. However, these feedback is what I have now.

[AndriianChestnykh]

We need to add getMultiRequestStatus(), I think

[AndriianChestnykh]

We don't need this method, and it doesn't even work properly anymore

[daveroga]

Removed

[AndriianChestnykh]

As we agreed, we don't need this struct in IAuthValidator

[AndriianChestnykh]

Just return bool, as agreed

[daveroga]

We will return uint256 userID as agreed.

[AndriianChestnykh]

The whitelisted validators mapping seem not to me used. The other mapping in the ValidatorWhitelist contract seem to be used.
If that's true than it can be removed

[daveroga]

Removed