Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks. #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add benchmarks. #112

wants to merge 2 commits into from

Conversation

mmaker
Copy link

@mmaker mmaker commented Jun 27, 2023

No description provided.

@mmaker mmaker mentioned this pull request Jun 27, 2023
@mmaker
Copy link
Author

mmaker commented Jul 13, 2023

hi! any news on this? /cc @phated

@@ -41,6 +42,7 @@
"chai": "^4.2.0",
"eslint": "^8.0.1",
"mocha": "^10.0.0",
"rollup": "^2.38.5"
"rollup": "^2.38.5",
"tinybench": "^2.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This looks great! Can you avoid the extra dependency? Perhaps using https://nodejs.org/api/perf_hooks.html 🤔

Copy link
Author

@mmaker mmaker Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing the pull request. I understand your concerns about adding another (dev)dependency. I chose it for its ease of use and detailed output. Over time, I've developed parsers tailored for its format in zka.lc, which allows for a deeper analysis of results.

While Node.js' perf hooks are useful, tinybench provides certain advantages in terms of comprehensiveness and user-friendliness. Transitioning now would require a significant overhaul of both benchmarks and the associated toolchain.

I'm open to discussing a potential compromise that might benefit us both.

@mmaker
Copy link
Author

mmaker commented Nov 3, 2023

@phated Could you include tinybench as a lightweight benchmarking dev-dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants