-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks. #112
base: master
Are you sure you want to change the base?
Add benchmarks. #112
Conversation
hi! any news on this? /cc @phated |
@@ -41,6 +42,7 @@ | |||
"chai": "^4.2.0", | |||
"eslint": "^8.0.1", | |||
"mocha": "^10.0.0", | |||
"rollup": "^2.38.5" | |||
"rollup": "^2.38.5", | |||
"tinybench": "^2.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This looks great! Can you avoid the extra dependency? Perhaps using https://nodejs.org/api/perf_hooks.html 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing the pull request. I understand your concerns about adding another (dev)dependency. I chose it for its ease of use and detailed output. Over time, I've developed parsers tailored for its format in zka.lc, which allows for a deeper analysis of results.
While Node.js' perf hooks are useful, tinybench provides certain advantages in terms of comprehensiveness and user-friendliness. Transitioning now would require a significant overhaul of both benchmarks and the associated toolchain.
I'm open to discussing a potential compromise that might benefit us both.
@phated Could you include tinybench as a lightweight benchmarking dev-dependency? |
No description provided.