extend GistInfo with Proof object #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmidyllic
reviewed
Nov 15, 2024
verifiable/did_doc.go
Outdated
| ReplacedAtTimestamp string `json:"replacedAtTimestamp"` | ||
| CreatedAtBlock string `json:"createdAtBlock"` | ||
| ReplacedAtBlock string `json:"replacedAtBlock"` | ||
| Proof *GistProof `json:"proof"` |
There was a problem hiding this comment.
we need to make it optional in json, because teoretically some objects could be saved by someone. (put omitEmpty)
verifiable/did_doc.go
Outdated
| Siblings []string `json:"siblings"` | ||
| Index string `json:"index"` | ||
| Value string `json:"value"` | ||
| AuxExistence bool `json:"auxExistence"` |
There was a problem hiding this comment.
we should create regular type here
with nodeAux, h_index, h_value.
root is already on upper level. Use merkletree.Proof object
There was a problem hiding this comment.
ah. maybe it should also contain type property with equality to SparseMerkleTreeProof and other fiellds from mtp
struct {
type : ProofType
merkeTree.Proof
}
vmidyllic
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.