Skip to content

Commit

Permalink
Merge pull request #482 from iden3/chore/fix-ci
Browse files Browse the repository at this point in the history
Fix CI tests
  • Loading branch information
OBrezhniev authored Apr 15, 2024
2 parents a29acef + 8b53dce commit e7f5a6f
Show file tree
Hide file tree
Showing 5 changed files with 818 additions and 637 deletions.
41 changes: 8 additions & 33 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Continuous Integration
on: [push, pull_request]
on:
push:
branches:
- main
pull_request:

jobs:
test:
Expand All @@ -11,7 +15,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: ["14", "16", "18"]
node-version: ["18", "20"]

steps:
- name: Checkout project
Expand Down Expand Up @@ -39,8 +43,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
# Pinning to 18.15 and dropped 20 due to https://github.com/NomicFoundation/hardhat/issues/3877
node-version: ["16", "18.15.0"]
node-version: ["18", "20"]

steps:
- name: Checkout project
Expand All @@ -64,34 +67,6 @@ jobs:
working-directory: smart_contract_tests
run: npm test

testv12:
name: Testv12
runs-on: ${{ matrix.os }}
timeout-minutes: 30

strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: ["12"]

steps:
- name: Checkout project
uses: actions/checkout@v2

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
check-latest: true
cache: "npm"

- name: Install dependencies
run: npm ci

- name: Run tests
run: npm run testv12

test-browser:
name: Test browser
runs-on: ${{ matrix.os }}
Expand All @@ -101,7 +76,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
node-version: ["18"]
node-version: ["18", "20"]

steps:
- name: Checkout project
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/tutorial.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
name: Check snarkjs tutorial

on: [push, pull_request]
on:
push:
branches:
- main
pull_request:

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x]
node-version: ["18", "20"]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ The low-level cryptography is performed directly in `wasm`, and uses worker thre
## Preliminaries

### Install node
First off, make sure you have a recent version of `Node.js` installed. While any version after `v12` should work fine, we recommend you install `v16` or later.
First off, make sure you have a recent LTS version of Node.js installed. Non-LTS and versions prior to v18 are not guaranteed to work.

If you’re not sure which version of Node you have installed, you can run:

Expand Down
Loading

0 comments on commit e7f5a6f

Please sign in to comment.