Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from js-sha3 to audited noble-hashes #310

Open
paulmillr opened this issue Feb 16, 2023 · 2 comments · May be fixed by #416
Open

Switch from js-sha3 to audited noble-hashes #310

paulmillr opened this issue Feb 16, 2023 · 2 comments · May be fixed by #416
Assignees
@paulmillr @phated

Comments

@paulmillr
Copy link

js-sha3 has a couple bugs. https://github.com/paulmillr/noble-hashes is an audited alternative developed with grant from Ethereum Foundation. It could be better to switch to it.
@phated
Copy link
Contributor

phated commented Aug 20, 2023

@paulmillr I'd love to make the switch. Do you have any bandwidth to send a PR? Otherwise I'm not sure when I'll be able to find the time.

@paulmillr paulmillr linked a pull request Aug 20, 2023 that will close this issue
Open
@paulmillr
Copy link
Author

@phated pr submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulmillr paulmillr

@phated phated

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from js-sha3 to audited noble-hashes paulmillr/snarkjs
2 participants
@paulmillr @phated