Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from js-sha3 to audited noble-hashes #416

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Switch from js-sha3 to audited noble-hashes #416

wants to merge 5 commits into from

Conversation

paulmillr
Copy link

@paulmillr paulmillr commented Aug 20, 2023 •
edited
Loading

@paulmillr paulmillr changed the title Switch from js-sha3 to noble-curves Switch from js-sha3 to audited noble-curves Sep 24, 2023
@paulmillr paulmillr changed the title Switch from js-sha3 to audited noble-curves Switch from js-sha3 to audited noble-hashes Sep 24, 2023
phated
phated approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

phated
phated suggested changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebuilt the CLI and it seems that we are blocked here by the use of node: imports until we upgrade the minimum version of nodejs we support.

I'll try harder to push that forward!

@paulmillr
Copy link
Author

But you don't even support v12 fully?

snarkjs/.github/workflows/tests.yml

Line 14 in 918b4ad

node-version: ["14", "16", "18"]

snarkjs/.github/workflows/tests.yml

Line 42 in 918b4ad

# Pinning to 18.15 and dropped 20 due to https://github.com/NomicFoundation/hardhat/issues/3877

In my opinion, supporting anything less than v18 is dangerous, because there are no security updates for these, and this is security-sensitive project. It's common now to use something else than node, such as bun / deno, so it's best to support bun instead of ancient node.

@phated
Copy link
Contributor

phated commented Sep 24, 2023

The minimum supported version isn't up to me 😂 like I said, I'll continue to press.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated requested changes

@xavi-pinsach xavi-pinsach Awaiting requested review from xavi-pinsach

@jbaylina jbaylina Awaiting requested review from jbaylina

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from js-sha3 to audited noble-hashes
2 participants
@paulmillr @phated