WIP: Generate plugins #410
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sigmachirality for any thoughts |
phated
commented
Aug 20, 2023
There was a problem hiding this comment.
This needs to be moved to its own repo and published as a package.
phated
commented
Aug 20, 2023
src/zkey_export_verifier.js
Outdated
There was a problem hiding this comment.
This needs to check the request protocol is supported and throw good error messages if not.
phated
commented
Aug 20, 2023
src/zkey_export_calldata.js
Outdated
There was a problem hiding this comment.
This needs to check the request protocol is supported and throw good error messages if not.
phated
commented
Aug 20, 2023
| // solidity genverifier [circuit_final.zkey] [verifier.sol] | ||
| async function zkeyExportSolidityVerifier(params, options) { | ||
| // zkey export verifier [circuit_final.zkey] [verifier.sol] | ||
| async function zkeyExportVerifier(params, options) { |
There was a problem hiding this comment.
This function needs to catch any error about unsupported protocols and show the user the plugin name and unsupported protocol name
phated
commented
Aug 20, 2023
| // solidity gencall <public.json> <proof.json> | ||
| async function zkeyExportSolidityCalldata(params, options) { | ||
| // zkey export calldata <public.json> <proof.json> | ||
| async function zkeyExportCalldata(params, options) { |
There was a problem hiding this comment.
This function needs to catch any error about unsupported protocols and show the user the plugin name and unsupported protocol name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP implementation of "generate" plugins, which provide verifier and calldata generator functions for the protocols that snarkjs supports.
Closes #340