bug(mindmap): fix image removal

[Idrinth]

The Pull Request is ready

• fixes mindmap images don't get removed properly #755
• all actions are passing
• only fixes a single issue

Overview

• fixes labeler config
• fixes weirdness around images in mindmap

Mindmap

• the change has been given a reason in the overview
• the change text is reasonable short

[coderabbitai]

Walkthrough

The collective has assimilated enhancements and modifications to the mindmap functionality. The transformation includes the reclassification of certain elements, the concealment of specific file types, the augmentation of the data structure, the refinement of the build process, and the advancement of TypeScript configurations. This assimilation ensures the optimisation of the mindmap's operational efficiency.

Changes

Files	Change Summary
.github/labeler.yml	Key renamed from research to mindmap within translation section.
.gitignore	Added path /mindmap/src/*.js for exclusion.
mindmap/data.yml	Nodes "Mindmap" and "History Website" added under specific sections.
mindmap/package.json	Included new TypeScript compilation script "tsc".
mindmap/src/show.ts	Functions for DOM manipulation to manage modals with images introduced.
mindmap/tools/data.js, mindmap/tsconfig.json	Updated to enhance JavaScript loading and set TypeScript compiler options.

Possibly related issues

• mindmap images don't get removed properly #755: The issue of mindmap images not being removed properly could be linked to the modifications in mindmap/src/show.ts, which introduces DOM manipulation functions that could address the image removal process.

🌟 Changes sweep through the code,
Like stars across the night sky bold.
Each line, a beacon in the mode,
Transforming mindmaps into gold.
🚀 Through the digital expanse, we code,
Our mission clear, our vision sold.
In unity, our efforts mould
The future, byte by byte, we hold.

code of rabbit has completed the assimilation of changes. The collective's efficiency has been enhanced. Await further instructions.

---

Recent Review Status

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 0cb0069 and a99391f.

Files selected for processing (7)

• .github/labeler.yml (1 hunks)
• .gitignore (1 hunks)
• mindmap/data.yml (1 hunks)
• mindmap/package.json (2 hunks)
• mindmap/src/show.ts (1 hunks)
• mindmap/tools/data.js (1 hunks)
• mindmap/tsconfig.json (1 hunks)

Files skipped from review due to trivial changes (1)

• .gitignore

Additional Context Used

Path-based Instructions (2)

mindmap/src/show.ts (1)

Pattern **/*.ts: Review the code for conformity with the .eslintrc files in / and /*/.

mindmap/tools/data.js (1)

Pattern **/*.js: Review the code for conformity with the .eslintrc files in / and /*/.

Additional comments not posted (9)

mindmap/tsconfig.json (2)

3-4: Target and module settings updated to ESNext and nodenext, respectively. Confirm compatibility with project dependencies and runtime environment.

---

7-7: Including TypeScript source files from src/**/*.ts. Ensure all necessary files are covered by this pattern.

.github/labeler.yml (1)

33-33: New label mindmap added with matching rule for mindmap/**/*. Verify the rule covers all relevant changes for this label.

mindmap/package.json (2)

15-15: New TypeScript compilation script added. Ensure it integrates well with the overall build process.

---

39-39: TypeScript version updated to ^5.4.4. Confirm compatibility with existing TypeScript code and dependencies.

mindmap/src/show.ts (1)

3-54: Introduced functions for DOM manipulation to handle modals with images. Ensure proper error handling and validation of inputs to prevent security vulnerabilities.

mindmap/tools/data.js (1)

104-104: Added type=module attribute to script tag. Verify this change aligns with the project's module loading strategy and browser compatibility requirements.

mindmap/data.yml (2)

263-263: Added "Mindmap" node. Confirm its placement and details align with the intended structure and content of the mindmap.

---

270-270: Added "History Website" node. Ensure its inclusion is consistent with the requirements and overall design of the mindmap.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud