-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ieee 255 overview #504
base: develop
Are you sure you want to change the base?
Ieee 255 overview #504
Conversation
This reverts commit 8881c34.
Hey @phamalis this looks good, please schedule some time with me this week so we can create/use redux selectors to get the real data. |
@phamalis Can you push your latest changes, and address the merge conflicts. What's the latest on this? |
…plate into ieee-255-overview git commit -m 'merge because pycharm asked me to pull before push, new update allows overview section to update with real data'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like Alisha has implemented a few selectors (which were outside the scope of this ticket/pr). This page is still missing the selector that fetches the number of broken/lost items. Which should probably be implemented in another ticket (since this one focuses on ui)
@@ -205,4 +205,29 @@ export const adminOrderTotalSelector = createSelector( | |||
(orderItems) => orderItems.reduce((accum) => accum + 1, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change name of adminOrderTotalSelector
to 'adminOrderTotalWithFiltersSelector', or similar.
@@ -205,4 +205,29 @@ export const adminOrderTotalSelector = createSelector( | |||
(orderItems) => orderItems.reduce((accum) => accum + 1, 0) | |||
); | |||
|
|||
export const adminOrderNewTotalSelector = createSelector( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get rid of 'new' in naming
…ot impacted by filters
Overview
Resolves 255
Created the Overview Section composed of cards that shows total number of
Unit Tests Created
Steps to QA