Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Danilo Pantani <[email protected]>
  • Loading branch information
julienrbrt and Pantani authored Feb 6, 2025
1 parent c7b3064 commit 17d110e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions connect/chains/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func (c *Config) Save() error {
}

connectConfigPath := path.Join(configDir, configName)
if err := os.WriteFile(connectConfigPath, out, 0644); err != nil {
if err := os.WriteFile(connectConfigPath, out, 0o644); err != nil {
return fmt.Errorf("error saving config: %w", err)
}

Expand Down Expand Up @@ -79,7 +79,7 @@ func ConfigDir() (string, error) {
}

dir := path.Join(igniteConfigDir, "connect")
if err := os.MkdirAll(dir, 0755); err != nil {
if err := os.MkdirAll(dir, 0o755); err != nil {
return "", fmt.Errorf("failed to create config directory: %w", err)
}

Expand Down
4 changes: 2 additions & 2 deletions connect/cmd/discover.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ type fetchErrMsg struct {
err error
}

// Initialize Bubble Tea program
// Init initialize Bubble Tea program
func (m *discoverCmdModel) Init() tea.Cmd {
return tea.Batch(fetchChainsCmd)
}

// Fetch the chains in the background
// fetchChainsCmd fetch the chains in the background
func fetchChainsCmd() tea.Msg {
cr := chains.NewChainRegistry()
if err := cr.FetchChains(); err != nil {
Expand Down
2 changes: 1 addition & 1 deletion connect/cmd/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/ignite/cli/v28/ignite/services/plugin"
)

func VersionHandler(ctx context.Context, cmd *plugin.ExecutedCommand) error {
func VersionHandler(_ context.Context, _ *plugin.ExecutedCommand) error {
version, ok := debug.ReadBuildInfo()
if !ok {
return errors.New("failed to get hubl version")
Expand Down

0 comments on commit 17d110e

Please sign in to comment.