Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'FailInfo' is not defined and type 'EventCallable<void>' is not assignable to type 'EventCallable<FailInfo<T>>' #526

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: 'FailInfo' is not defined and type 'EventCallable<void>' is not assignable to type 'EventCallable<FailInfo<T>>' #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6556ad
Exported FailInfo type and changed field type to "otherwise"
BlackPoretsky Jan 18, 2025
9f0b264
Added FailInfo type to "retry" public API
BlackPoretsky Jan 18, 2025
b3ec67a
Support for importing the FailInfo type has been added, and the type …
BlackPoretsky Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-pillows-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@farfetched/core": patch
---

Support for importing the FailInfo type has been added, and the type for the otherwise field in the retry configuration object has been extended (enabling the use of an event of type EventCallable<void>).
1 change: 1 addition & 0 deletions packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export { createHeadlessMutation } from './mutation/create_headless_mutation';
export { createJsonMutation } from './mutation/create_json_mutation';

// Retry public API
export { type FailInfo } from './retry/retry';
export { retry } from './retry/retry';
export { exponentialDelay, linearDelay } from './retry/delay';

Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/retry/retry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
} from '../remote_operation/type';
import { type RetryMeta } from './type';

type FailInfo<Q extends RemoteOperation<any, any, any, any>> = {
export type FailInfo<Q extends RemoteOperation<any, any, any, any>> = {
params: RemoteOperationParams<Q>;
error: RemoteOperationError<Q>;
meta: ExecutionMeta;
Expand All @@ -51,7 +51,7 @@ type RetryConfig<
RemoteOperationParams<Q>,
MapParamsSource
>;
otherwise?: EventCallable<FailInfo<Q>>;
otherwise?: EventCallable<FailInfo<Q> | void>;
supressIntermediateErrors?: boolean;
};

Expand Down