Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@withease/redux #63

Merged
merged 56 commits into from
Dec 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
eb9228c
Setup package basics
AlexandrHoroshih Dec 11, 2023
c2b61f1
Setup peer deps
AlexandrHoroshih Dec 11, 2023
0c4e900
Build initial implementation
AlexandrHoroshih Dec 11, 2023
4045855
nx love
igorkamyshev Dec 11, 2023
c1f22e2
Add tests
AlexandrHoroshih Dec 11, 2023
1708e39
Run all tests
AlexandrHoroshih Dec 11, 2023
f37593c
Add RTK integration test
AlexandrHoroshih Dec 11, 2023
6b2a83e
Make types work
AlexandrHoroshih Dec 11, 2023
06ac086
Test logs
AlexandrHoroshih Dec 11, 2023
c5c6367
Fix test name
AlexandrHoroshih Dec 11, 2023
0e84e06
Initial release of Redux interop package for Effector
AlexandrHoroshih Dec 11, 2023
858e0a4
Add minimal API docs
AlexandrHoroshih Dec 11, 2023
d0d2702
Start redux migration article
AlexandrHoroshih Dec 11, 2023
fee6ff3
Update packages/redux-interop/src/lib/redux-interop.ts
AlexandrHoroshih Dec 11, 2023
1aee5df
Add test for cycle of updates
AlexandrHoroshih Dec 12, 2023
1e00656
Add more docs on migration
AlexandrHoroshih Dec 12, 2023
e3666fd
Add note about middleware with side-effects
AlexandrHoroshih Dec 12, 2023
79575cb
Move article to magazine
AlexandrHoroshih Dec 12, 2023
7bbaee6
`redux-interop` -> `redux`
AlexandrHoroshih Dec 12, 2023
7c50414
`createReduxInterop` -> `createReduxIntegration`
AlexandrHoroshih Dec 12, 2023
8eac4c2
Better text
AlexandrHoroshih Dec 12, 2023
215035b
Fix linter format
AlexandrHoroshih Dec 12, 2023
65ca543
Better package title in the navbar
AlexandrHoroshih Dec 12, 2023
cc592e6
Make `reduxInt.dispatch` an Effect
AlexandrHoroshih Dec 13, 2023
cd9edee
Fix internal types mismatch
AlexandrHoroshih Dec 13, 2023
0ff73b9
Add tests for redux thunks to effects
AlexandrHoroshih Dec 13, 2023
998b51a
Add note on converting thunks
AlexandrHoroshih Dec 13, 2023
0f2068b
Add Thunk guide
AlexandrHoroshih Dec 13, 2023
d49a1b9
Support thunk-like stuff in types
AlexandrHoroshih Dec 13, 2023
6f61f9d
Update apps/website/docs/magazine/migration_from_redux.md
AlexandrHoroshih Dec 13, 2023
59732ff
Update apps/website/docs/redux/index.md
AlexandrHoroshih Dec 13, 2023
7e5e576
Update apps/website/docs/redux/index.md
AlexandrHoroshih Dec 13, 2023
450ff76
Update apps/website/docs/redux/index.md
AlexandrHoroshih Dec 13, 2023
168fc11
Update apps/website/docs/redux/index.md
AlexandrHoroshih Dec 13, 2023
dfe13e1
Fix article
AlexandrHoroshih Dec 13, 2023
698f5e5
Beatufy texts
AlexandrHoroshih Dec 13, 2023
3b997ce
Add Summary to the article
AlexandrHoroshih Dec 13, 2023
10d25a2
Fix linter
AlexandrHoroshih Dec 13, 2023
8045871
Add guide for sagas
AlexandrHoroshih Dec 13, 2023
bfd6a30
Add partial migration example
AlexandrHoroshih Dec 13, 2023
05bf95e
Fix typos
igorkamyshev Dec 14, 2023
a48373c
Make docs more native for the site
igorkamyshev Dec 14, 2023
bf8f911
Make build and publish process the same
igorkamyshev Dec 14, 2023
0a1eac7
Fix typos
igorkamyshev Dec 14, 2023
5e77376
Format
igorkamyshev Dec 14, 2023
117eb61
Change icon
igorkamyshev Dec 14, 2023
d4eb99d
`interop.$store` -> `$reduxStore`
AlexandrHoroshih Dec 14, 2023
fa133b9
Expose $state store directly
AlexandrHoroshih Dec 14, 2023
dcd128d
Use `reduxInterop.$state` in the docs
AlexandrHoroshih Dec 14, 2023
98fd627
Allow Effector 22 in peer deps
AlexandrHoroshih Dec 14, 2023
ad7186e
Add redux-saga integration tests
AlexandrHoroshih Dec 14, 2023
14d3396
Update Sagas guide
AlexandrHoroshih Dec 14, 2023
b8ac28c
Prepare release as a major 1.0.0
AlexandrHoroshih Dec 14, 2023
685944d
Fix typos
igorkamyshev Dec 14, 2023
bbf408a
No swc
igorkamyshev Dec 14, 2023
08cb9fe
Fix wording
AlexandrHoroshih Dec 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typos
igorkamyshev committed Dec 14, 2023
commit 685944df53296a696ce6582d0693fe5a22ae769f
6 changes: 3 additions & 3 deletions apps/website/docs/magazine/migration_from_redux.md
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ This guide explains how to perform a gradual, non-blocking code migration from R
First, you need to install the `effector` package. See [the official documentation for instructions](https://effector.dev/en/introduction/installation/).

:::tip
It is also highly recommended setting up the official [Effector ESlint Plugin](https://eslint.effector.dev/), so it would be easier for you to follow Effector's best practices.
It is also highly recommended setting up the official [Effector ESLint Plugin](https://eslint.effector.dev/), so it would be easier for you to follow Effector's best practices.
:::

Also, it is recommended to read at least some of the Effector's docs, so it is easier to follow the guide.
@@ -686,12 +686,12 @@ You can move parts of the logic from any saga step-by-step, without rewriting th
2. To read state of the Effector's Store in the Saga you can also use `call` + `getState()` method of a store, like this: `yield call(() => $someStore.getState())`.

:::warning
Note that it is generally **not recommended** to call the `getState` method of Effector Stores, because it is imperative and non-reactive. This method is an escape-hatch for cases where there is no other way.
Note that it is generally **not recommended** calling the `getState` method of Effector Stores, because it is imperative and non-reactive. This method is an escape-hatch for cases where there is no other way.

But you can sometimes use it in Sagas, since they themselves are imperative and non-reactive, and you won't always have the option to write the state to the effector right away.
:::

Here is a earlier "Data fetching" example, but in a state of partial rewrite.
Here is an earlier "Data fetching" example, but in a state of partial rewrite.

```ts
// effector model