fix: shortest.paths() no longer fails (#1222)

igraph · Feb 8, 2024 · 31a33dd · 31a33dd
2 parents e98211d + 8ebdb01
commit 31a33dd
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1,645 deletions.
diff --git a/R/structural.properties.R b/R/structural.properties.R
@@ -86,6 +86,8 @@ topological.sort <- function(graph, mode = c("out", "all", "in")) { # nocov star
 #' @export
 shortest.paths <- function(graph, v = V(graph), to = V(graph), mode = c("all", "out", "in"), weights = NULL, algorithm = c("automatic", "unweighted", "dijkstra", "bellman-ford", "johnson")) { # nocov start
   lifecycle::deprecate_soft("2.0.0", "shortest.paths()", "distances()")
+  algorithm <- igraph.match.arg(algorithm)
+  mode <- igraph.match.arg(mode)
   distances(graph = graph, v = v, to = to, mode = mode, weights = weights, algorithm = algorithm)
 } # nocov end
 

diff --git a/revdep/README.md b/revdep/README.md
@@ -1,41 +1,2 @@
 # Revdeps
 
-## Failed to check (7)
-
-|package    |version |error |warning |note |
-|:----------|:-------|:-----|:-------|:----|
-|geostan    |0.5.3   |1     |        |     |
-|HLSM       |?       |      |        |     |
-|Seurat     |?       |      |        |     |
-|streamDAG  |?       |      |        |     |
-|TDA        |1.9     |1     |        |     |
-|TestAnaAPP |0.1.5   |1     |        |     |
-|treestats  |1.0.3   |1     |        |     |
-
-## New problems (22)
-
-|package           |version |error  |warning |note |
-|:-----------------|:-------|:------|:-------|:----|
-|[countland](problems.md#countland)|0.1.1   |__+1__ |        |     |
-|[DiagrammeR](problems.md#diagrammer)|1.0.10  |__+1__ |        |1    |
-|[dnet](problems.md#dnet)|1.1.7   |__+1__ |        |     |
-|[dragon](problems.md#dragon)|1.2.1   |__+1__ |        |2    |
-|[EGAnet](problems.md#eganet)|2.0.3   |__+1__ |        |1    |
-|[ggnetwork](problems.md#ggnetwork)|0.5.12  |__+1__ |        |1    |
-|[inferCSN](problems.md#infercsn)|0.99.9  |__+1__ |        |1    |
-|[intergraph](problems.md#intergraph)|2.0-3   |__+1__ |        |     |
-|[manynet](problems.md#manynet)|0.3.0   |__+1__ |        |2    |
-|[migraph](problems.md#migraph)|1.2.1   |__+1__ |        |     |
-|[molnet](problems.md#molnet)|0.1.0   |__+1__ |        |     |
-|[nat](problems.md#nat)|1.8.23  |__+1__ |        |     |
-|[nbTransmission](problems.md#nbtransmission)|1.1.3   |__+2__ |        |     |
-|[netcom](problems.md#netcom)|2.1.6   |__+2__ |        |1    |
-|[nosoi](problems.md#nosoi)|1.1.0   |__+1__ |        |     |
-|[oddnet](problems.md#oddnet)|0.1.0   |__+1__ |        |     |
-|[pcalg](problems.md#pcalg)|2.7-9   |__+1__ |        |3    |
-|[phyloseqGraphTest](problems.md#phyloseqgraphtest)|0.1.0   |__+2__ |        |2    |
-|[rgraph6](problems.md#rgraph6)|2.0-3   |__+1__ |        |     |
-|[riverconn](problems.md#riverconn)|0.3.28  |__+1__ |        |     |
-|[tidygraph](problems.md#tidygraph)|1.3.0   |__+2__ |        |     |
-|[VertexSort](problems.md#vertexsort)|0.1-1   |__+1__ |        |     |
-
diff --git a/revdep/cran.md b/revdep/cran.md
@@ -1,90 +1,7 @@
 ## revdepcheck results
 
-We checked 30 reverse dependencies (29 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
+We checked 33 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 22 new problems
- * We failed to check 6 packages
+ * We saw 0 new problems
+ * We failed to check 0 packages
 
-Issues with CRAN packages are summarised below.
-
-### New problems
-(This reports the first line of each new failure)
-
-* countland
-  checking tests ... ERROR
-
-* DiagrammeR
-  checking tests ... ERROR
-
-* dnet
-  checking examples ... ERROR
-
-* dragon
-  checking tests ... ERROR
-
-* EGAnet
-  checking examples ... ERROR
-
-* ggnetwork
-  checking tests ... ERROR
-
-* inferCSN
-  checking examples ... ERROR
-
-* intergraph
-  checking tests ... ERROR
-
-* manynet
-  checking tests ... ERROR
-
-* migraph
-  checking examples ... ERROR
-
-* molnet
-  checking examples ... ERROR
-
-* nat
-  checking tests ... ERROR
-
-* nbTransmission
-  checking tests ... ERROR
-  checking re-building of vignette outputs ... ERROR
-
-* netcom
-  checking examples ... ERROR
-  checking re-building of vignette outputs ... ERROR
-
-* nosoi
-  checking re-building of vignette outputs ... ERROR
-
-* oddnet
-  checking examples ... ERROR
-
-* pcalg
-  checking tests ... ERROR
-
-* phyloseqGraphTest
-  checking examples ... ERROR
-  checking re-building of vignette outputs ... ERROR
-
-* rgraph6
-  checking re-building of vignette outputs ... ERROR
-
-* riverconn
-  checking re-building of vignette outputs ... ERROR
-
-* tidygraph
-  checking examples ... ERROR
-  checking tests ... ERROR
-
-* VertexSort
-  checking examples ... ERROR
-
-### Failed to check
-
-* geostan    (NA)
-* Seurat     (NA)
-* streamDAG  (NA)
-* TDA        (NA)
-* TestAnaAPP (NA)
-* treestats  (NA)