Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update vendored sources to igraph/igraph@a9ca8a74eb8cfeefe7e46… #1550

Closed
wants to merge 0 commits into from

Conversation

szhorvat
Copy link
Member

@szhorvat szhorvat commented Oct 7, 2024

…193f7f524b2039fe20e

fix: fix handling of small vertex counts (zero and one) for centralization tmax functions
docs: improve centralization docs
fuzzer: use libxml2 2.13.4 [skip ci]

@krlmlr @maelle This brings a C core bugfix I made today to R/igraph. I recommend inclusion in 2.1.0. The chance for revdepcheck failures is rather low, and if they do occur, it's because other packages were expecting invalid values from igraph.

Copy link
Contributor

aviator-app bot commented Oct 7, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat
Copy link
Member Author

szhorvat commented Oct 8, 2024

I included another small change.

@szhorvat
Copy link
Member Author

szhorvat commented Oct 8, 2024

I think this needs no manual merge. For as long as tests pass, the C core is now auto-updated. I forgot about this.

I'd still like to request inclusion in 2.1.0. You can close this PR once making a decision on that.

@maelle
Copy link
Contributor

maelle commented Oct 11, 2024

@krlmlr

@krlmlr krlmlr closed this Oct 14, 2024
@krlmlr krlmlr force-pushed the update-c-core-2024-10-07 branch from 9fdb2ee to 0d96334 Compare October 14, 2024 05:53
@krlmlr
Copy link
Contributor

krlmlr commented Oct 14, 2024

Releasing 2.1.1 to CRAN, with the source changes from the main branch.

@szhorvat szhorvat deleted the update-c-core-2024-10-07 branch November 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants