Skip to content

Commit

Permalink
Remove rubocop-rspec
Browse files Browse the repository at this point in the history
  • Loading branch information
mullermp committed Jun 10, 2024
1 parent f09d93b commit 197b1d7
Show file tree
Hide file tree
Showing 6 changed files with 63 additions and 187 deletions.
13 changes: 11 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,22 @@ inherit_from: .rubocop_todo.yml

require:
- rubocop-rake
- rubocop-rspec

AllCops:
NewCops: enable
SuggestExtensions: false
TargetRubyVersion: 2.5
Exclude:
- 'lib/http/2/huffman_statemachine.rb'

Gemspec/RequireMFA:
Enabled: false
Enabled: false

Metrics:
Exclude:
- 'spec/**/*.rb'

# For some reason, Metrics disable doesn't cover this
Metrics/BlockLength:
Exclude:
- 'spec/**/*.rb'
136 changes: 2 additions & 134 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,11 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2024-06-05 01:25:45 UTC using RuboCop version 1.28.0.
# on 2024-06-10 16:07:08 UTC using RuboCop version 1.28.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 16
# This cop supports safe auto-correction (--auto-correct).
# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
# SupportedHashRocketStyles: key, separator, table
# SupportedColonStyles: key, separator, table
# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
Layout/HashAlignment:
Exclude:
- 'spec/connection_spec.rb'

# Offense count: 1
# This cop supports safe auto-correction (--auto-correct).
# Configuration parameters: EnforcedStyle.
Expand Down Expand Up @@ -52,7 +42,7 @@ Metrics/AbcSize:
Max: 181

# Offense count: 7
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods, inherit_mode.
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
# IgnoredMethods: refine
Metrics/BlockLength:
Max: 82
Expand All @@ -77,11 +67,6 @@ Metrics/CyclomaticComplexity:
Metrics/MethodLength:
Max: 132

# Offense count: 1
# Configuration parameters: CountComments, CountAsOne.
Metrics/ModuleLength:
Max: 101

# Offense count: 1
# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
Metrics/ParameterLists:
Expand Down Expand Up @@ -110,113 +95,6 @@ Naming/VariableNumber:
Exclude:
- 'example/server.rb'

# Offense count: 2
RSpec/Be:
Exclude:
- 'spec/stream_spec.rb'

# Offense count: 2
RSpec/BeforeAfterAll:
Exclude:
- 'spec/spec_helper.rb'
- 'spec/rails_helper.rb'
- 'spec/support/**/*.rb'
- 'spec/huffman_spec.rb'

# Offense count: 65
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
Exclude:
- 'spec/client_spec.rb'
- 'spec/compressor_spec.rb'
- 'spec/connection_spec.rb'
- 'spec/framer_spec.rb'
- 'spec/hpack_test_spec.rb'
- 'spec/huffman_spec.rb'
- 'spec/server_spec.rb'
- 'spec/stream_spec.rb'

# Offense count: 92
# Configuration parameters: CountAsOne.
RSpec/ExampleLength:
Max: 34

# Offense count: 1
RSpec/ExpectInHook:
Exclude:
- 'spec/compressor_spec.rb'

# Offense count: 10
# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
# Include: **/*_spec*rb*, **/spec/**/*
RSpec/FilePath:
Exclude:
- 'spec/buffer_spec.rb'
- 'spec/client_spec.rb'
- 'spec/compressor_spec.rb'
- 'spec/connection_spec.rb'
- 'spec/emitter_spec.rb'
- 'spec/framer_spec.rb'
- 'spec/hpack_test_spec.rb'
- 'spec/huffman_spec.rb'
- 'spec/server_spec.rb'
- 'spec/stream_spec.rb'

# Offense count: 239
# Configuration parameters: AssignmentOnly.
RSpec/InstanceVariable:
Exclude:
- 'spec/compressor_spec.rb'
- 'spec/connection_spec.rb'
- 'spec/emitter_spec.rb'
- 'spec/framer_spec.rb'
- 'spec/hpack_test_spec.rb'
- 'spec/huffman_spec.rb'
- 'spec/server_spec.rb'
- 'spec/stream_spec.rb'

# Offense count: 1
RSpec/LeakyConstantDeclaration:
Exclude:
- 'spec/emitter_spec.rb'

# Offense count: 25
# Configuration parameters: .
# SupportedStyles: have_received, receive
RSpec/MessageSpies:
EnforcedStyle: receive

# Offense count: 120
RSpec/MultipleExpectations:
Max: 7

# Offense count: 7
# Configuration parameters: IgnoreSharedExamples.
RSpec/NamedSubject:
Exclude:
- 'spec/compressor_spec.rb'

# Offense count: 9
RSpec/NestedGroups:
Max: 4

# Offense count: 2
RSpec/RepeatedDescription:
Exclude:
- 'spec/connection_spec.rb'

# Offense count: 4
RSpec/RepeatedExample:
Exclude:
- 'spec/connection_spec.rb'
- 'spec/stream_spec.rb'

# Offense count: 1
RSpec/UnspecifiedException:
Exclude:
- 'spec/emitter_spec.rb'

# Offense count: 1
# This cop supports safe auto-correction (--auto-correct).
Rake/Desc:
Expand Down Expand Up @@ -245,13 +123,3 @@ Style/GuardClause:
Style/OptionalBooleanParameter:
Exclude:
- 'lib/http/2/flow_buffer.rb'

# Offense count: 34
# This cop supports safe auto-correction (--auto-correct).
# Configuration parameters: EnforcedStyle, MinSize, WordRegex.
# SupportedStyles: percent, brackets
Style/WordArray:
Exclude:
- 'spec/compressor_spec.rb'
- 'spec/connection_spec.rb'
- 'spec/huffman_spec.rb'
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ group :development do
# Last supported version for Ruby 2.5
gem 'rubocop', '1.28'
gem 'rubocop-rake', require: false
gem 'rubocop-rspec', require: false
end

group :docs do
Expand Down
Loading

0 comments on commit 197b1d7

Please sign in to comment.