Skip to content

Commit

Permalink
Remove frozen string literal false from specs
Browse files Browse the repository at this point in the history
  • Loading branch information
mullermp committed Jun 5, 2024
1 parent b4ee747 commit a715f1f
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 13 deletions.
8 changes: 4 additions & 4 deletions spec/framer_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# frozen_string_literal: false
# frozen_string_literal: true

require 'helper'

Expand Down Expand Up @@ -345,9 +345,9 @@
stream: 1,
max_age: 1_402_290_402, # 4
port: 8080, # 2
proto: 'h2-13', # 1 + 5
host: 'www.example.com', # 1 + 15
origin: 'www.example.com' # 15
proto: String.new('h2-13'), # 1 + 5
host: String.new('www.example.com'), # 1 + 15
origin: String.new('www.example.com') # 15
}
bytes = f.generate(frame)
expected = [0, 43, 0xa, 0, 1, 1_402_290_402, 8080].pack('CnCCNNn')
Expand Down
20 changes: 11 additions & 9 deletions spec/helper.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# frozen_string_literal: false
# frozen_string_literal: true

require './spec/support/deep_dup'

Expand All @@ -17,11 +17,13 @@
include HTTP2::Error
# rubocop: enable Style/MixinUsage

REQUEST_HEADERS = [%w[:scheme https],
%w[:path /],
%w[:authority example.com],
%w[:method GET],
%w[a b]].freeze
REQUEST_HEADERS = [
%w[:scheme https],
%w[:path /],
%w[:authority example.com],
%w[:method GET],
%w[a b]
].freeze
RESPONSE_HEADERS = [%w[:status 200]].freeze

module FrameHelpers
Expand Down Expand Up @@ -128,9 +130,9 @@ def altsvc_frame
type: :altsvc,
max_age: 1_402_290_402, # 4
port: 8080, # 2 reserved 1
proto: 'h2-12', # 1 + 5
host: 'www.example.com', # 1 + 15
origin: 'www.example.com' # 15
proto: String.new('h2-12'), # 1 + 5
host: String.new('www.example.com'), # 1 + 15
origin: String.new('www.example.com') # 15
}
end

Expand Down

0 comments on commit a715f1f

Please sign in to comment.