Add base64 as a dependency for Ruby 3.4 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
reviewed
Jun 10, 2024
| @@ -11,5 +11,7 @@ Gem::Specification.new do |spec| | |||
| spec.license = 'MIT' | |||
| spec.files = Dir["LICENSE", "README.md", "lib/**/*.rb"] | |||
|
|
|||
| spec.add_runtime_dependency 'base64' | |||
There was a problem hiding this comment.
Should we do this in a different minor version from the other fixes? (in particular I'm thinking, if this causes issues for some users, being able to use the smaller version of the gem would be useful).
There was a problem hiding this comment.
I think it's fine to not do that. The current experience is already what's expected, and a new version can be a carrot to upgrade (using new ruby, smaller gem, etc..)
alextwoods
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds base64 as a dependency as required by Ruby 3.4