Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nils to initialize to prevent syntax error #43

Closed
wants to merge 1 commit into from
Closed

Add nils to initialize to prevent syntax error #43

wants to merge 1 commit into from

Conversation

dfried
Copy link

@dfried dfried commented Dec 27, 2015

There seems to be an issue with 0.8.0 where you can't initialize a stream. I think it's a simple syntax error and this fixed it.

@igrigorik
Copy link
Owner

Hmm, are you referring to the rbx build?

@dfried
Copy link
Author

dfried commented Dec 28, 2015

No, I was getting a syntax error on the first two args having colons at the end.

@igrigorik
Copy link
Owner

Which Ruby version? All the specs pass here and on Travis?

@alloy
Copy link
Contributor

alloy commented Jan 16, 2016

This is because the gemspec only requires Ruby 2.0.0, but keyword arguments without default values weren’t supported before 2.1.0.

I have a change to the gemspec for this alloy@74f387e, I added it as part of my #44 PR. I should revert that if you choose to fix it by adding default values, as this PR does.

@igrigorik
Copy link
Owner

Are you aware of any stats on 2.0.0 use/adoption vs newer versions? Ruby site indicates that 2.0.0 will EOL'ed soon, but with no particular date.

/cc @mad-p wdyt?

@igrigorik igrigorik closed this in 028cfa9 Jan 29, 2016
@mkonecny
Copy link

Why not merge this PR and support a much wider range of Ruby installations? The end-result is exactly the same.

Our systems are currently on Ubuntu 14.04 (the latest LTE) with Ruby 2.0, which makes it a very common setup.

@igrigorik
Copy link
Owner

https://www.ruby-lang.org/en/news/2016/02/24/support-plan-of-ruby-2-0-0-and-2-1/

As it has been announced before, all support for Ruby 2.0.0 has ended today. Bug and security fixes from more recent Ruby versions will no longer be backported to 2.0.0, and no further patch release of 2.0.0 will be released.

We don't want to promote use of 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants