Refactor metadata_extract.py #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses SQLAlchemy...
|
How was this tested? Thanks @deldesir! |
Optimization: Removes the for loop for total_duration specifically and incorporated the var into the subsequent for loop. Fixes TaskDownload call where session was being passed wrongly. Cleans up live_status variable.
|
How to test
|
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
metadata_extract.pyfile to improve code readability, maintainability, and performance.Key Changes Introduced:
Replaced direct SQLite queries with SQLAlchemy ORM for database interactions.
Enhanced logging for better traceability and debugging within the task class.
Improved error handling to manage exceptions more gracefully.
Refactored the subprocess execution and metadata updating logic.
Tested on Ubuntu 24.04